Auto-transform to identity when using generateTexture (pixijs#8349)

michaeljherrmann · May 19, 2022 · 55ca370 · 55ca370
1 parent f0bc7fc
commit 55ca370
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/packages/core/src/AbstractRenderer.ts b/packages/core/src/AbstractRenderer.ts
@@ -1,5 +1,5 @@
 import { hex2string, hex2rgb, EventEmitter, deprecation } from '@pixi/utils';
-import { Matrix, Rectangle } from '@pixi/math';
+import { Matrix, Rectangle, Transform } from '@pixi/math';
 import { MSAA_QUALITY, RENDERER_TYPE } from '@pixi/constants';
 import { settings } from '@pixi/settings';
 import { RenderTexture } from './renderTexture/RenderTexture';
@@ -10,6 +10,7 @@ import type { IRenderingContext } from './IRenderingContext';
 import type { IRenderableContainer, IRenderableObject } from './IRenderableObject';
 
 const tempMatrix = new Matrix();
+const tempTransform = new Transform();
 
 export interface IRendererOptions extends GlobalMixins.IRendererOptions
 {
@@ -377,13 +378,17 @@ export abstract class AbstractRenderer extends EventEmitter
         tempMatrix.tx = -region.x;
         tempMatrix.ty = -region.y;
 
+        const transform = displayObject.transform;
+
+        displayObject.transform = tempTransform;
+
         this.render(displayObject, {
             renderTexture,
-            clear: false,
-            transform: tempMatrix,
-            skipUpdateTransform: !!displayObject.parent
+            transform: tempMatrix
         });
 
+        displayObject.transform = transform;
+
         return renderTexture;
     }
 

diff --git a/packages/core/src/IRenderableObject.ts b/packages/core/src/IRenderableObject.ts
@@ -1,4 +1,4 @@
-import type { Rectangle } from '@pixi/math';
+import type { Rectangle, Transform } from '@pixi/math';
 import type { Renderer } from './Renderer';
 
 /**
@@ -9,6 +9,8 @@ import type { Renderer } from './Renderer';
 interface IRenderableObject {
     /** Object must have a parent container */
     parent: IRenderableContainer;
+    /** Object must have a transform */
+    transform: Transform;
     /** Before method for transform updates */
     enableTempParent(): IRenderableContainer;
     /** Update the transforms */