Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements prevent use of Sphinx 3.1.0 #541

Closed
jmckenna opened this issue Jun 8, 2020 · 3 comments
Closed

requirements prevent use of Sphinx 3.1.0 #541

jmckenna opened this issue Jun 8, 2020 · 3 comments
Assignees

Comments

@jmckenna
Copy link

jmckenna commented Jun 8, 2020

@jakobandersen
Copy link
Collaborator

If I remember correctly there should be no Sphinx changes to prevent a bump to Sphinx>=3.0,<3.2.
There may be cases in the documentation that could benefit from

  • C, added scope control directives, :rst:dir:c:namespace,
    :rst:dir:c:namespace-push, and :rst:dir:c:namespace-pop.

Perhaps we should open an issue accumulating TODOs for an overview of when it may be beneficial to raise to lower Sphinx version bound.

@vermeeren vermeeren self-assigned this Jun 8, 2020
vermeeren added a commit that referenced this issue Jun 8, 2020
@vermeeren
Copy link
Collaborator

vermeeren commented Jun 8, 2020

@jmckenna Fixed in breathe v4.19.1, just released it. Thanks for the issue.

@jakobandersen Yeah I think that would be a good idea, we could also document it in some COMPATIBILITY.md file in the repository, that might be easier to track long-term. I am fine with both cases.

(Appears the Sphinx branch 3.0.x has been removed, will update CICD in a sec. Edit: 75d0803)

@jmckenna
Copy link
Author

jmckenna commented Jun 9, 2020

Verified here. Thanks for the quick fix @vermeeren

@jmckenna jmckenna closed this as completed Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants