Improve error handling

michaeljoseph · Jul 14, 2014 · 7f514a0 · 7f514a0
1 parent f576c02
commit 7f514a0
Showing 1 changed file with 12 additions and 14 deletions.
diff --git a/changes/packaging.py b/changes/packaging.py
@@ -11,20 +11,18 @@
 def install():
     module_name, dry_run, new_version = config.common_arguments()
     commands = ['setup.py', 'clean', 'sdist', 'bdist_wheel']
-
-    shell.handle_dry_run(sh.python, tuple(commands))
-
-    with util.mktmpdir() as tmp_dir:
-        venv.create_venv(tmp_dir=tmp_dir)
-        for distribution in path('dist').files():
-            try:
-                venv.install(distribution, tmp_dir)
-                log.info('Successfully installed %s sdist', module_name)
-                if verification.run_test_command():
-                    log.info('Successfully ran test command: %s',
-                             config.arguments['--test-command'])
-            except Exception, e:
-                raise Exception('Error installing distribution %s' % distribution, e)
+    try:
+        if (shell.handle_dry_run(sh.python, tuple(commands))):
+            with util.mktmpdir() as tmp_dir:
+                venv.create_venv(tmp_dir=tmp_dir)
+                for distribution in path('dist').files():
+                    venv.install(distribution, tmp_dir)
+                    log.info('Successfully installed %s sdist', module_name)
+                    if verification.run_test_command():
+                        log.info('Successfully ran test command: %s',
+                                 config.arguments['--test-command'])
+    except Exception, e:
+        raise Exception('Error installing distribution %s' % distribution, e)
 
 
 def upload():