Doesn't work well when package name doesn't match module name

[michaeljoseph]

Great tool! I'm running into this problem though.
Package name is django-clickbank but module is django_clickbank.

Sureiya/django-clickbank@e671358

(django_clickbank)kin@boxed-xawesome:~/Work/repositories/django-clickbank$ changes --tox django_clickbank install
What is the release version for "django_clickbank" [Default: 0.1.2]: 
warning: sdist: standard file not found: should have one of README, README.rst, README.txt

Cannot find sdist dist/django_clickbank-0.1.2.tar.gz
INFO:changes.cli:Successfully installed django_clickbank sdist

[michaeljoseph]

Ditto #49.

[michaeljoseph]

Thanks for the issue :)

[coveralls]

Coverage increased (+0.26%) when pulling 7c59ed0 on support-package-module-mismatch into da05d41 on master.

[Sureiya]

I guess that works! Thanks.

[michaeljoseph]

Ugh, it's still not right though.

• s/app_name/module_name/g
• s/module_name/package_name/g
• Specify an alternate requirements file #56
• Use the default #57
• test with https://github.com/Sureiya/django-clickbank

[Sureiya]

I unfortunately still haven't been able to get this version to run at all. Its stalling on updating the version.
I just end up with

__version__ = ''
__url__ = ''

[michaeljoseph]

Ok, I'll fix up and test with your project.

[Sureiya]

Either way, I think it makes more sense for app_name to be renamed module_name.

# django_clickbank/ __init__.py
...
__package_name__ = 'django-clickbank'

# Changes

package_name = getattr(arguments['--package-name'], django_clickbank.__package_name__)

Or perhaps the order could be --package-name > package_name > <module_name>/<app_name>

[michaeljoseph]

Yeah, I actually think the best solution for this is to make them the same in your project 😉

[michaeljoseph]

djlickbank

[Sureiya]

I only say that, because different module and package names are pretty common. And the naming convention for django projects is django-

[coveralls]

Coverage increased (+0.16%) when pulling 70c9311 on support-package-module-mismatch into e42c815 on master.

[coveralls]

Coverage increased (+0.16%) when pulling 70c9311 on support-package-module-mismatch into e42c815 on master.

[coveralls]

Coverage increased (+0.42%) when pulling d693c3c on support-package-module-mismatch into e42c815 on master.

[coveralls]

Coverage increased (+0.42%) when pulling 9479f76 on support-package-module-mismatch into e42c815 on master.

[michaeljoseph]

Looking hopeful:

± michael at mathematical in .../django-clickbank using virtualenv: django-clickbank on master:36e64 ✓
$ pip install -U ../changes; changes --tox --requirements=test-requirements.txt --package-name=django-clickbank django_clickbank install 
Unpacking /Users/michael/Source/changes
...
Successfully installed changes
Cleaning up...
INFO:changes.probe:Checking project for changes requirements.
INFO:changes.probe:On Github? True
INFO:changes.probe:setup.py? True
INFO:changes.probe:test-requirements.txt? True
INFO:changes.probe:Runs tests? True
INFO:changes.probe:CHANGELOG.md? True
INFO:changes.probe:Has module metadata? True
What is the release version for "django_clickbank" [Default: 0.1.4]: 
INFO:changes.packaging:Successfully installed django_clickbank sdist
INFO:changes.packaging:Successfully ran test command: None

[coveralls]

Coverage increased (+0.42%) when pulling beffa15 on support-package-module-mismatch into e42c815 on master.

[michaeljoseph]

Claiming victory, let me know please @Sureiya.
☕

[Sureiya]

Thanks, its working now. Its pausing on pushing tags though. How does sh need an explicit interactive mode? I think its failing because I'm using git http without any kind of autologin, so its basically freezing on auth without any output. I'm not sure if thats possible or easy to fix, so you may want to add to the docs that you need to be using ssh for git.

[michaeljoseph]

Please paste me what happens when you try to install with the latest version?

[michaeljoseph]

I can work on reproducing your use-case, but I'll definitely add that assumption to the docs. Thanks for contributing :)