Additional JVM tunable options #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can anyone explain the intended goal of the rspec to match the processed output of the cassandra-env.sh template with a predefined config file? Is it to have a predefined version of default values? Some other purpose? |
|
@msilvey the idea is to render a template with a particular config and assert on what comes out. |
|
OK, I'll render a new cassandra-env.sh for the changes and reopen this. |
|
Updated with a new cassandra-env.sh test and rendered output. |
michaelklishin
added a commit
that referenced
this pull request
Jan 7, 2016
Additional JVM tunable options
|
@msilvey please update change log and credit yourself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding some additional JVM tuning parameters. The defaults are based on either JDK 8 defaults as per the results of 'java -XX:+PrintFlagsFinal' or pre-existing options in the cassandra-env template.