Fixes for systemd, style and spec tests #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michaelklishin Could you have a look at this? |
michaelklishin
approved these changes
Jul 12, 2017
|
@nacx thank you very much! |
|
And build is back to green! Yay! |
|
@nacx will try to do one before EOW. |
|
That would be great. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a notification in the systemd recipe. It has three commits, being the first one the relevant one. The other commits just fix the style and some minor failures in the spec tests.
systemdrecipe to send a delayed notification for the C* service enable. There is no need to enable it:immediately. Doing that affects resources that are subscribed to theservice[cassandra]status, as enabling it immediately would trigger a status change and enqueue eagerly their subscriptions, which might have expected notifications to be delayed, as defined in the:restartaction. Notifications should be better triggered the same way regardless of the action, to have consistent a behavior on subscribers.