Allow customizing client-properties #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| (is (rmq/open? conn)) | ||
| (await-event-propagation) | ||
| (let [conns (mgmt/list-connections)] | ||
| (is (= 1 (count conns))) |
There was a problem hiding this comment.
This test passes in isolation but not when lein test is run. We should close all other connections if (the HTTP API client can do it) if we want to assert on a single connection.
There was a problem hiding this comment.
Oh whoops, I'd fixed this locally shortly after opening the PR, but forgotten to update before I went out.
glenjamin
force-pushed
the
client-properties
branch
from
98cdc6a
to
1188c2c
Compare
|
Thank you! |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, fixes #105
:connection-namecan now be used to name connections.:update-client-propertiesallows clients to read and modify the default client-properties, this one i'm less sure about - the API is arguably a little bit odd, but it does provide the most flexibility.