Support replacing existing jobs

Fixes #20
michaelklishin · May 2, 2013 · fab6093 · fab6093
1 parent f71b8de
commit fab6093
Showing 1 changed file with 7 additions and 9 deletions.
diff --git a/src/main/java/com/novemberain/quartz/mongodb/MongoDBJobStore.java b/src/main/java/com/novemberain/quartz/mongodb/MongoDBJobStore.java
@@ -889,14 +889,8 @@ protected void storeTrigger(OperableTrigger newTrigger, ObjectId jobId, boolean
   protected ObjectId storeJobInMongo(JobDetail newJob, boolean replaceExisting) throws ObjectAlreadyExistsException {
     JobKey key = newJob.getKey();
 
-    BasicDBObject job = keyToDBObject(key);
-
-    if (replaceExisting) {
-      DBObject result = jobCollection.findOne(job);
-      if (result != null) {
-        result = job;
-      }
-    }
+    BasicDBObject keyDbo = keyToDBObject(key);
+    BasicDBObject job    = keyToDBObject(key);
 
     job.put(JOB_KEY_NAME, key.getName());
     job.put(JOB_KEY_GROUP, key.getGroup());
@@ -906,7 +900,11 @@ protected ObjectId storeJobInMongo(JobDetail newJob, boolean replaceExisting) th
     job.putAll(newJob.getJobDataMap());
 
     try {
-      jobCollection.insert(job);
+      if (replaceExisting) {
+        jobCollection.update(keyDbo, job);
+      } else {
+        jobCollection.insert(job);
+      }
 
       return (ObjectId) job.get("_id");
     } catch (DuplicateKey e) {