Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stringify all keys when converting map to JobDataMap skipping nested maps. #16

Merged
merged 1 commit into from
Jan 12, 2015
Merged

Stringify all keys when converting map to JobDataMap skipping nested maps. #16

merged 1 commit into from
Jan 12, 2015

Conversation

nbeloglazov
Copy link
Contributor

Contains 2 changes:

  1. Stringify all keys from a map, not only keywords. Before that change non-keyword keys like numbers, symbols weren't converted to strings. Seems like all keys should be strings based on description from this commit: ff5e37e
  2. Don't convert nested maps. Fixes to-job-data converts records to maps #12.

Added unit test that covers both changes.

michaelklishin added a commit that referenced this pull request Jan 12, 2015
@michaelklishin
Merge pull request #16 from nbeloglazov/records-maps-problem
b6b155c 
Stringify all keys when converting map to JobDataMap skipping nested maps.
@michaelklishin michaelklishin merged commit b6b155c into michaelklishin:master Jan 12, 2015
@michaelklishin
Copy link
Owner

Thank you!

@nbeloglazov nbeloglazov deleted the records-maps-problem branch January 22, 2015 03:53
@nbeloglazov nbeloglazov mentioned this pull request Jan 23, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

to-job-data converts records to maps
2 participants
@nbeloglazov @michaelklishin