Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http client helper functions check for errors in the wrong order #158

Closed
mammothbane opened this issue Jul 15, 2020 · 1 comment
Closed

http client helper functions check for errors in the wrong order #158

mammothbane opened this issue Jul 15, 2020 · 1 comment
Milestone
2.4.0

Comments

@mammothbane
Copy link

mammothbane commented Jul 15, 2020 •
edited

See e.g. https://github.com/michaelklishin/rabbit-hole/blob/master/client.go#L85-L89

If constructing the request fails, this code panics because the request is nil, rather than returning the error.
@michaelklishin
Copy link
Owner

Addressed in c751dcf.

@michaelklishin michaelklishin added this to the 2.2.1 milestone Jul 15, 2020
michaelklishin added a commit that referenced this issue Jul 15, 2020
@michaelklishin
Closes #158
c751dcf
@michaelklishin michaelklishin added this to the 2.3.1 milestone Jul 15, 2020
@michaelklishin michaelklishin modified the milestones: 2.3.1, 2.4.0 Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4.0
Development

No branches or pull requests
2 participants
@michaelklishin @mammothbane