Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PagedListQueuesWithParameters endpoint + Tests #118

Merged
merged 5 commits into from Oct 19, 2018

Conversation

jordanbcooper
Copy link
Contributor

@jordanbcooper jordanbcooper commented Aug 2, 2018

So we can loop through "api/queues?page=1".. etc.

@michaelklishin
Copy link
Owner

This looks promising, thank you.

@jordanbcooper
Copy link
Contributor Author

Thanks! We're still testing using it in a newrelic integration, but having trouble getting concurrency working, for cases where there are a large number of queues in the cluster. The page feature helped start this, though.

@jordanbcooper
Copy link
Contributor Author

jordanbcooper commented Aug 3, 2018

https://github.com/scottschulthess/newrelic-integration-rabbitmq/blob/master/rabbitmq.go#L113-L159

This is the closest we've gotten. May have it working tomorrow.

https://github.com/jordanbcooper/newrelic-integration-rabbitmq/blob/master/rabbitmq.go#L152-L163

^^ This works well (commented out) for clusters with a few queues. Our cluster with the most queues (dev, go figure) took 59s to pull...not useful for newrelic infrastructure/insights.

@michaelklishin
Copy link
Owner

@jordanbcooper are there more changes coming to this PR? I'm not sure how to interpret your last comment, sorry.

@jordanbcooper
Copy link
Contributor Author

No worries, sorry for the confusion. Nothing else to add here

@jordanbcooper
Copy link
Contributor Author

@michaelklishin This is fine to merge.

@michaelklishin michaelklishin merged commit 7fa9b8b into michaelklishin:master Oct 19, 2018
@michaelklishin michaelklishin added this to the 1.5.0 milestone Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants