Update jenkins mode to use suiteTitleSeparatedBy and update documentation #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @hmafzal! Also thanks for updating the readme too 🙂 |
|
@clayreimann no problem! Will there be a new release with these changes coming soon? |
|
@hmafzal They'll be out before too long, did a bunch of PR cleanup yesterday with a bit more to go. If I don't forget I'll drop a line when I do the release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating #93
The current getJenkinsClassname() method currently joins the class names by a
.. This change updates it to use the configuredsuiteTitleSeparatedByvalue.This is not a breaking change as the
suiteTitleSeparatedByoption defaults to . when jenkinsMode is set to trueThis also updates the documentation to use the correct
suiteTitleSeparatedByby and call out thatsuiteTitleSeparedByis deprecated