Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't load xdebug twice! #47

Merged
merged 1 commit into from
Nov 11, 2019
Merged

Conversation

wmortada
Copy link
Contributor

@wmortada wmortada commented Nov 6, 2019

See issue #46

@michaelmcandrew
Copy link
Owner

Referencing #46.

Thanks, William. Removing it from here and keeping it in debug.ini looks like the right way to do it

@michaelmcandrew michaelmcandrew merged commit d93ecd4 into michaelmcandrew:master Nov 11, 2019
@wmortada wmortada deleted the xdebug branch November 15, 2019 14:39
@michaelmcandrew
Copy link
Owner

@wmortada I also added 6ee433c.

The civicrm directory gets overridden here

`rm -r $dir/../civicrm`;
`cp -r $dir/civicrm/php$defaultVersion $dir/../civicrm`;
when you run publish/generate.php. So in future, rather than editing files in the civicrm directory directly, you should edit files in the publish/templates directory and then run publish/generate.php.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants