-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test #7
Open
michaelparkadze
wants to merge
75
commits into
feat/main-product-carousel
Choose a base branch
from
master
base: feat/main-product-carousel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
test #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
login and register base routes
Updated the register route and added input validation with joi.
After some research on angular and handling server errors I rather have 'message' key instead of 'error' because of the better readability.
A service that makes it easy to make api requests, currently supports [get, post, put].
Updated the login route and added input validation with joi.
- Restructured login and register into auth module - Created auth service to handle auth related operations - Created interceptor service to add auth token in request header - Created guard service to handle protected routes - Created token storage service to handle session storage related operations *Future refactor incoming...
Improved readability, dynamically change displayed right CTA [login, profile] (Temporary) until a dropdown menu will be made to display all options
In order to develop a UI that looks good faster and some more complex components.
In order to change email in addition to the full name, the query had to be updated to be based on the id and not email.
Return an object instead of an array containing the object.
Created the layout for product page with the api call to get all the products data to showcase. Added swiper for the photo gallery of the product images.
Replaced the mock data with the actual data of the products and price, and added the remove functionality.
Changed the trigger of the dropdown to be click instead of hover.
Removed unnecessary nav on desktop and added a menu icon button instead of the placeholder button for the side menu
Organized it a bit better, added a close icon option, logout button when user is logged in and added a few nice hover animations.
Created a 3 step form to checkout for user to add his billing and payment and purchase his goods. no validation what so ever was added to the forms in the steps.
Created the get orders route that returns all the orders for a specific user.
I added a street name column It seemed to be missing a name
Added a street_name column to sql_dump.sql
[Fix] Auth broken by fname field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test