Fix log_min_messages for "LOG" messages #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Postgres's handling of LOG level messages is ... curious. They're treated as between DEBUG1 and INFO for the client however for the server log they're treated as equal to ERROR. Copy the static is_log_level_output function from elog.c to implement this.
LOG_SERVER_ONLY didn't exist before 9.6 but we can use COMMERROR which is now just an alias for it and always existed before.
|
Thanks Greg for the patch. I have merged both commits and pushed them as 935ca4f. I have also changed one comment to be more consistent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Postgres's interpretation of LOG level messages is ... curious. They're treated as between DEBUG1 and INFO for the client but as equal to ERROR for the server log. Copy the function from elog.c to implement this.