Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worth mentioning Cario dependency #4

Closed
hughrawlinson opened this issue Jul 24, 2016 · 3 comments
Closed

Worth mentioning Cario dependency #4

hughrawlinson opened this issue Jul 24, 2016 · 3 comments

Comments

@hughrawlinson
Copy link
Contributor

I ran npm install --save get-image-data and node-gyp complained that I didn't have cairo installed. I haven't checked but I guess it's either a dependency of this project, or a dependency of a dependency of this project. It's worth noting in the Readme that it's required.

@michaelrhodes
Copy link
Owner

Good point, I’m thinking of making canvas a peer dependency in the package.json because native dependencies are a pain when you’re only installing for the browser variant. Obviously a note in the README would follow, but does that sound good to you?

@hughrawlinson
Copy link
Contributor Author

Yep, that sounds great to me :)

@michaelrhodes
Copy link
Owner

michaelrhodes commented Jan 16, 2017

Sweet, it’s a peer dependency as of 3.0.0. I updated the README accordingly—I don’t mention the Cairo dependency explicitly, but it’s alluded to in my disclaimer, so hopefully that’ll do. Thanks for the help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants