Changes to support manual interfaces and other issues #31

busterswt · 2017-11-29T19:08:02Z

This PR introduces enhancements for supporting 'manual' interfaces (those without IPs). It also introduces a 'fix' for bonds in Debian/Ubuntu to bring up member interfaces prior to trying to bring up the bond. Lastly, introduced a new var to pause the playbooks after interfaces are bounced, but before facts are gathered, due to some server interfaces not being UP/active prior to fact gathering.

…d interface

Added a fix to ifup slave interfaces in pre-up before bringing up Bon…

Added code to support interface without IP

Added manual interface config and pre-up

…e to slow server. Interface(s) were listed as not active in facts, but really just too slow

markgoddard

Thanks @busterswt.

markgoddard · 2017-12-04T09:39:17Z

defaults/main.yml

@@ -17,3 +17,4 @@ interfaces_pkg_state: installed
 interfaces_ether_interfaces: []
 interfaces_bridge_interfaces: []
 interfaces_bond_interfaces: []
+playbook_pause_time: 3


Could you rename this with a prefix of interfaces_?

Sure can. Please see handler comment.

markgoddard · 2017-12-04T09:52:03Z

handlers/main.yml

    - Gather facts
    - Verify network interfaces exist
    - Verify network interfaces are active
    - Verify network interface IP configuration
    - Verify bond interface slaves
    - Verify bridge interface ports

+- name: Pause playbook to give interfaces time to recover
+  pause:
+    seconds: "{{ playbook_pause_time }}"


If there's a race going on here, is this always going to work?

To which race might you be referring to? The idea behind this was simply to avoid hitting the gather_facts tasks before the interfaces were up on the server. If there's a better way of doing this I'm totally open to it. What I was seeing was the interfaces weren't all up by the time facts were gathered, resulting in failures when checking for active interfaces.

I guess my point was, if we need to sleep here, that suggests to me there is a race condition between the network being 'up' and us gathering facts. Adding a sleep isn't necessarily going to guarantee that we gather facts after the interfaces are up - how do we know how long to sleep for? Would that value work everywhere?

Perhaps the default of 3 seconds is sufficient to work in most environments. It's not something I've needed to do, but then I primarily use CentOS.

markgoddard · 2017-12-04T10:10:50Z

templates/bond_Debian.j2

+{% if item.bond_slaves is defined and item.bond_mode == 'active-backup' %}
+bond-slaves none
+{% for slave in item.bond_slaves %}
+pre-up (sleep 2 && ifup {{ slave }}) &


This seems quite brittle. It's run as a background task, so will likely start after the master has been brought up. It all seems a bit racy to me. Shouldn't the OS networking scripts handle these dependencies automatically? It seems to work on Ubuntu 16.04.

I'm happy to remove this. I've seen issues where the bond master would not come up unless the slaves were up, but bringing up slaves first brings up the bond master. This may not be an issue with your configuration, so I'll take it out.

markgoddard · 2017-12-04T10:24:22Z

templates/bond_Debian.j2

+{% if item.bond_mode is defined %}
+bond-mode {{ item.bond_mode }}
+{% endif %}
+bond-miimon {{ item.bond_miimon|default(100) }}


We're missing these options for manual: downdelay, updelay, xmit_hash_policy.

Right on. I'll take a look and fix that, too.

* Use source images * Need to specify bash for &> syntax Issues worked around: * Manually configuring bridge via ip commands makes ifup fail to bring up the link. Adds a kayobe-network-bootstrap Zuul CI role that adds persistent configuration for the all-in-one network. * bridge not active after interfaces role bounce. Added a pause, similar to michaelrigart/ansible-role-interfaces#31 * fails installing docker python module for kolla user. WARNING: The repository located at mirror-int.ord.rax.opendev.org is not a trusted or secure host and is being ignored ERROR: No matching distribution found for docker===4.4.0 Adding trusted host for PyPI mirror. * Tenks fails to create block devices - missing qemu-img (in qemu-utils) * Tenks qemu emulator is different on Ubuntu Remaining issues: * Bare metal testing is unreliable on Ubuntu - some jobs see IPMI failures such as the following: ipmitool chassis bootdev pxe Error setting Chassis Boot Parameter 5\nError setting Chassis Boot Parameter 0\n Bare metal testing is disabled on Ubuntu for now. Depends-On: https://review.opendev.org/766984 Depends-On: https://review.opendev.org/766958 Story: 2004960 Task: 29393 Change-Id: I1985efae7c18f55c3ff7c27c17d6242523904f3e

* Update kayobe from branch 'master' to 0e3ec62471b98d69cb5f46b8a9e1ebbefe9c4a13 - Merge "CI: add Ubuntu overcloud deploy job" - CI: add Ubuntu overcloud deploy job * Use source images * Need to specify bash for &> syntax Issues worked around: * Manually configuring bridge via ip commands makes ifup fail to bring up the link. Adds a kayobe-network-bootstrap Zuul CI role that adds persistent configuration for the all-in-one network. * bridge not active after interfaces role bounce. Added a pause, similar to michaelrigart/ansible-role-interfaces#31 * fails installing docker python module for kolla user. WARNING: The repository located at mirror-int.ord.rax.opendev.org is not a trusted or secure host and is being ignored ERROR: No matching distribution found for docker===4.4.0 Adding trusted host for PyPI mirror. * Tenks fails to create block devices - missing qemu-img (in qemu-utils) * Tenks qemu emulator is different on Ubuntu Remaining issues: * Bare metal testing is unreliable on Ubuntu - some jobs see IPMI failures such as the following: ipmitool chassis bootdev pxe Error setting Chassis Boot Parameter 5\nError setting Chassis Boot Parameter 0\n Bare metal testing is disabled on Ubuntu for now. Depends-On: https://review.opendev.org/766984 Depends-On: https://review.opendev.org/766958 Story: 2004960 Task: 29393 Change-Id: I1985efae7c18f55c3ff7c27c17d6242523904f3e

* Use source images * Need to specify bash for &> syntax Issues worked around: * Manually configuring bridge via ip commands makes ifup fail to bring up the link. Adds a kayobe-network-bootstrap Zuul CI role that adds persistent configuration for the all-in-one network. * bridge not active after interfaces role bounce. Added a pause, similar to michaelrigart/ansible-role-interfaces#31 * fails installing docker python module for kolla user. WARNING: The repository located at mirror-int.ord.rax.opendev.org is not a trusted or secure host and is being ignored ERROR: No matching distribution found for docker===4.4.0 Adding trusted host for PyPI mirror. * Tenks fails to create block devices - missing qemu-img (in qemu-utils) * Tenks qemu emulator is different on Ubuntu Remaining issues: * Bare metal testing is unreliable on Ubuntu - some jobs see IPMI failures such as the following: ipmitool chassis bootdev pxe Error setting Chassis Boot Parameter 5\nError setting Chassis Boot Parameter 0\n Bare metal testing is disabled on Ubuntu for now. Depends-On: https://review.opendev.org/766984 Depends-On: https://review.opendev.org/766958 Story: 2004960 Task: 29393 Change-Id: I1985efae7c18f55c3ff7c27c17d6242523904f3e

busterswt and others added 9 commits October 21, 2017 18:21

Added a fix to ifup slave interfaces in pre-up before bringing up Bon…

f8b17a1

…d interface

Merge pull request #1 from busterswt/fix_bond

627314a

Added a fix to ifup slave interfaces in pre-up before bringing up Bon…

Added code to support interface without IP

b416e60

Added manual interface config and pre-up

559246c

Merge pull request #2 from busterswt/fix_bridge_debian

d732303

Added code to support interface without IP

Merge pull request #3 from busterswt/fix_bond

612fa25

Added manual interface config and pre-up

Added a pause after bouncing interfaces and before gathering facts du…

bb4c7f1

…e to slow server. Interface(s) were listed as not active in facts, but really just too slow

Fixed a dumb quote issue and removed the debug line

77e33e1

Removed a register

7ce280e

michaelrigart requested a review from markgoddard December 4, 2017 09:37

markgoddard reviewed Dec 4, 2017

View reviewed changes

root added 2 commits December 11, 2017 09:49

support manual for ethernet interface

d371a27

Updated bond config for debian

73eb1a3

markgoddard mentioned this pull request Dec 22, 2020

Support pausing before checking interface status #97

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changes to support manual interfaces and other issues #31

Changes to support manual interfaces and other issues #31

busterswt commented Nov 29, 2017

markgoddard left a comment

markgoddard Dec 4, 2017

busterswt Dec 4, 2017

markgoddard Dec 4, 2017

busterswt Dec 4, 2017

markgoddard Dec 4, 2017

markgoddard Dec 4, 2017

busterswt Dec 4, 2017

markgoddard Dec 4, 2017

busterswt Dec 4, 2017

markgoddard Dec 4, 2017

Changes to support manual interfaces and other issues #31

Are you sure you want to change the base?

Changes to support manual interfaces and other issues #31

Conversation

busterswt commented Nov 29, 2017

markgoddard left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment