Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HEXDIG wrong #7

Closed
mxmlnkn opened this issue May 2, 2019 · 3 comments
Closed

HEXDIG wrong #7

mxmlnkn opened this issue May 2, 2019 · 3 comments
Assignees
Labels
Milestone

Comments

@mxmlnkn
Copy link

mxmlnkn commented May 2, 2019

For the simplest rule h = HEXDIG, the online converter gives me:

^([0-9]|%[Xx]41\-46|%[Xx]61\-66)$

which matches things like:

9
%x41-46
%X41-46

and should relatively surely be instead:

^[0-9A-Fa-f]$
@michaelrsweet
Copy link
Owner

Will investigate - it should just substitute the characters (and was working...)

@michaelrsweet michaelrsweet self-assigned this May 3, 2019
@michaelrsweet michaelrsweet added this to the Stable milestone Oct 9, 2019
@michaelrsweet
Copy link
Owner

Confirmed this is the case. Investigating this further...

michaelrsweet added a commit that referenced this issue Oct 9, 2019
@michaelrsweet
Copy link
Owner

[master 5ab1955] Fix HEXDIG core rule (Issue #7)

After staring at it and adding some debug messages I realized that the HEXDIG definition had double quotes around the character constants... Fixed in Git master, will push to abnf.msweet.org once I've made the rest of the fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants