Fix a signed character issue with fuzzer-generated "code" (Issue #4)

michaelrsweet · Jul 3, 2019 · f030a57 · f030a57
1 parent 19532db
commit f030a57
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/README.md b/README.md
@@ -18,6 +18,7 @@ Changes in v3.2
 
 - The default HTML stylesheet no longer puts an outline box around monospaced
   text (Issue #2)
+- Fixed a signed character issue with fuzzer-generated "code" (Issue #4)
 - Fixed a buffer overflow issue with fuzzer-generated "code" (Issue #5)
 - Now use the base name of the cover image filename in HTML output.
 - Fixed some markdown parsing issues.

diff --git a/codedoc.c b/codedoc.c
@@ -2406,7 +2406,7 @@ scan_file(filebuf_t   *file,		/* I - File to scan */
                     DEBUG_puts("Identifier: <<<< / >>>\n");
 
                     ch = get_nth_text(type, -1, NULL)[0];
-		    mxmlNewText(type, isalnum(ch) || ch == '_', "/");
+		    mxmlNewText(type, isalnum(ch & 255) || ch == '_', "/");
 		  }
 		}
 		break;
@@ -2847,7 +2847,7 @@ scan_file(filebuf_t   *file,		/* I - File to scan */
                   DEBUG_puts("Identifier: <<<< * >>>\n");
 
                   ch = get_nth_text(type, -1, NULL)[0];
-		  mxmlNewText(type, isalnum(ch) || ch == '_', "*");
+		  mxmlNewText(type, isalnum(ch & 255) || ch == '_', "*");
 		}
 		break;
 
@@ -2875,7 +2875,7 @@ scan_file(filebuf_t   *file,		/* I - File to scan */
                   DEBUG_puts("Identifier: <<<< + >>>\n");
 
                   ch = get_nth_text(type, -1, NULL)[0];
-		  mxmlNewText(type, isalnum(ch) || ch == '_', "+");
+		  mxmlNewText(type, isalnum(ch & 255) || ch == '_', "+");
 		}
 		break;
 
@@ -2885,7 +2885,7 @@ scan_file(filebuf_t   *file,		/* I - File to scan */
                   DEBUG_puts("Identifier: <<<< - >>>\n");
 
                   ch = get_nth_text(type, -1, NULL)[0];
-		  mxmlNewText(type, isalnum(ch) || ch == '_', "-");
+		  mxmlNewText(type, isalnum(ch & 255) || ch == '_', "-");
 		}
 		break;
 
@@ -2895,12 +2895,12 @@ scan_file(filebuf_t   *file,		/* I - File to scan */
                   DEBUG_puts("Identifier: <<<< = >>>\n");
 
                   ch = get_nth_text(type, -1, NULL)[0];
-		  mxmlNewText(type, isalnum(ch) || ch == '_', "=");
+		  mxmlNewText(type, isalnum(ch & 255) || ch == '_', "=");
 		}
 		break;
 
             default :			/* Other */
-	        if (isalnum(ch) || ch == '_' || ch == '.' || ch == ':' || ch == '~')
+	        if (isalnum(ch & 255) || ch == '_' || ch == '.' || ch == ':' || ch == '~')
 		{
 		  state = STATE_IDENTIFIER;
 
@@ -3368,7 +3368,7 @@ scan_file(filebuf_t   *file,		/* I - File to scan */
           break;
 
       case STATE_IDENTIFIER :		/* Inside a keyword or identifier */
-	  if (isalnum(ch) || ch == '_' || ch == '[' || ch == ']' ||
+	  if (isalnum(ch & 255) || ch == '_' || ch == '[' || ch == ']' ||
 	      (ch == ',' && (parens > 1 || (type && !enumeration && !function))) ||
 	      ch == ':' || ch == '.' || ch == '~')
 	  {