Autoheader improvements #329
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autoheader was complaining about missing templates for several defines.
autoheader (which is called during autoreconf) overwrites/generates config.h.in. As it contains several global constants, include them in the generated config.h.in via AC_DEFINEs.
|
I don't use autoreconf or autoheader, which are a) unnecessary and b) problematic because they can remove things without warning (as you've discovered). Similarly I do not use automake or libtool which are not as portable as their maintainers believe. Without a compelling reason, I don't want to make major changes to how the HTMLDOC build system works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current configure.ac does not properly work with autoheader, which is called during autoreconf.
By moving some constants from config.h.in into configure.ac, the generated config.h.in will retain them.
And also a bunch of AC_DEFINEs were using outdated syntax, so autoheader complained about missing templates for them.