-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configure: Add --with-systemd option #50
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zdohnal So I think AC_ARG_WITH (as in --with-systemd[=PATH]
) would be more appropriate, and in the makefile the "else" should be changed to an "elif" with the condition that $(unitdir)
isn't empty allowing --without-system
to be supported.
Also, shouldn't we be using ${libdir}/systemd/...
for the default path and not hardcoding to /usr/lib/systemd
? It's fine for a system package to put things in /usr but most local/site installs use /usr/local
(default prefix) or /opt
(FHS).
TBH setting the path via configuration option looked as an overkill for me (AFAIK if someone installs systemd, its system service files would lie in /usr/lib/systemd/system), so env variable looked fine for such a corner case.
Ah, this one I've missed - that's what I get from switching from one thing to another... thx.
Using |
The option enables disabling installation of systemd unit file or setting a different path for systemd unit file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do a little cleanup for cross-compilation, but otherwise LGTM.
Thank you for looking into it! :) |
NEW:
The option gives a way how to disable systemd unit file installation and provides a way how to define a different systemd unit dir.
OLD version:
(some distitributions can still work without systemd)
via UNITDIR variable (if not used, /usr/lib/systemd/system is chosen)
/etc/systemd/system is for admin's overrides