Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS-SD registrations are not updated when the hostname changes #282

Closed
michaelrsweet opened this issue Jul 27, 2023 · 4 comments
Closed
Assignees
Labels
bug Something isn't working priority-high
Milestone

Comments

@michaelrsweet
Copy link
Owner

PAPPL passes system->hostname when registering services, but doesn't update those registrations when system->hostname changes. Need to force re-registration, otherwise the target host for the services will still point to the old hostname...

@michaelrsweet michaelrsweet self-assigned this Jul 27, 2023
@michaelrsweet michaelrsweet added bug Something isn't working priority-high labels Jul 27, 2023
@michaelrsweet michaelrsweet added this to the Stable milestone Jul 27, 2023
@michaelrsweet
Copy link
Owner Author

Investigating - this happens for Avahi already, just mDNSResponder that doesn't keep track of name changes...

@michaelrsweet
Copy link
Owner Author

Preliminary fix pushed to master and v1.3.x:

[master 10ecdc8] Fix hostname change detection with mDNSResponder (Issue #282)

[v1.3.x ef29596] Fix hostname change detection with mDNSResponder (Issue #282)

@michaelrsweet
Copy link
Owner Author

Needed some Apple-specific code, too:

[master 42b2750] Add Apple-specific hostname change detection (Issue #282)

[v1.3.x 87158d7] Add Apple-specific hostname change detection (Issue #282)

michaelrsweet added a commit that referenced this issue Jul 28, 2023
@michaelrsweet
Copy link
Owner Author

Actually, found a better way to track hostname changes with mDNSResponder that works on macOS and other mDNSResponder platforms with the same code:

[master f91eab7] Switch to using a PTR record query for the loopback address to get hostname changes with mDNSResponder (Issue #282)

[v1.3.x 6f14994] Switch to using a PTR record query for the loopback address to get hostname changes with mDNSResponder (Issue #282)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-high
Projects
None yet
Development

No branches or pull requests

1 participant