Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push containers to registries #19

Closed
michaelsauter opened this issue Apr 5, 2014 · 5 comments
Closed

Push containers to registries #19

michaelsauter opened this issue Apr 5, 2014 · 5 comments

Comments

@michaelsauter
Copy link
Owner

We could extend Crane with a push command and the manifest with registries:

"registries": {
  "one": {},
  "two": {}
}

And then you could use it like that: crane push --registry one.

@jsierles
Copy link
Contributor

jsierles commented Jun 2, 2014

This seems useful - I'm using crane now on a build server and a production release area. The push step is what now takes up the most time. Would this mean removing the registry name from the image?

@michaelsauter
Copy link
Owner Author

Nice to hear that Crane is used elsewhere!

I'm not a 100% sure what you mean by by "the push step is what now takes up the most time". The idea here was to allow the user to push all containers at the same time to a registry (instead of having to do that one by one). So the idea is just to wrap docker push in a similar fashion to what Crane does to docker start for example.

Is that what you thought as well or do you have a different idea?

@jsierles
Copy link
Contributor

jsierles commented Jun 3, 2014

Yep this is what I'd use it for. The only question is whether the registry URL would still be included in the image name, like: "myprivateregistry.local:reponame"

@michaelsauter
Copy link
Owner Author

Ah, now I see what you meant. I implemented (very) basic push support in da90ec6 now. I realised we don't need a separate registries configuration to start with. Also, I don't want to add passwords to the file anyway.

However, it might make sense to be able to specify email and username in the config, and then add a password option to the push command. What I haven't figured out yet is how that would work when you've got multiple registries (which right now is possible). Ideally, there should be a way to use the push command non-interactively.

@michaelsauter
Copy link
Owner Author

Closing for now. Any improvements can be discussed in a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants