-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push containers to registries #19
Comments
This seems useful - I'm using crane now on a build server and a production release area. The push step is what now takes up the most time. Would this mean removing the registry name from the image? |
Nice to hear that Crane is used elsewhere! I'm not a 100% sure what you mean by by "the push step is what now takes up the most time". The idea here was to allow the user to push all containers at the same time to a registry (instead of having to do that one by one). So the idea is just to wrap Is that what you thought as well or do you have a different idea? |
Yep this is what I'd use it for. The only question is whether the registry URL would still be included in the image name, like: "myprivateregistry.local:reponame" |
Ah, now I see what you meant. I implemented (very) basic push support in da90ec6 now. I realised we don't need a separate However, it might make sense to be able to specify email and username in the config, and then add a |
Closing for now. Any improvements can be discussed in a separate issue. |
We could extend Crane with a
push
command and the manifest with registries:And then you could use it like that:
crane push --registry one
.The text was updated successfully, but these errors were encountered: