Fix bug in readQuotedString: recognize leading escaped character #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First character of a quoted string may be an escaped character, as in "\"A special name\"". The previous implementation only checks for backslash after the first character.
|
Oh, I also completely missed this case. Thank you for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of readQuotedString only checks for a
\after the first character (after the while checknextChar != ", the next character is immediately added). If the quoted string starts like\"some text..., this leads to unexpected behavior: the backslash is added and the subsequent"terminates the string.I have fixed this and added an appropriate test. The implementation should also be cleaner now.
My apologies for not getting this right in the first place; I must have been too tired when I first implemented this.