Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General fixes #135

Merged
merged 4 commits into from
Jun 1, 2022
Merged

General fixes #135

merged 4 commits into from
Jun 1, 2022

Conversation

falkTX
Copy link
Contributor

@falkTX falkTX commented May 22, 2022

Just spent some time trying out the high-dpi branch, these are a couple of commits on top of it.

  1. make clean was not fully clean
  2. disable dpf-based file browser dialog, prevents dependency on dbus (also rtaudio not set to be used on jack standalones, as it is too easy to get feedback loops if we activate the default audio device from the user)
  3. fixing some compiler warnings (plus removing some unused freeverb code, which was also giving warnings)
  4. no need to get window to call setGeometryConstraints

tested here with standalones and carla lv2 hosting, plugin scales properly.

image

only the vst3 does not work correctly for high-dpi, but vst3 support in dpf is still experimental anyway.

If you want to try this in carla, easiest way to do it is running QT_SCALE_FACTOR=2 carla from the terminal.
Then make sure it prints this line:

Frontend pixel ratio is 2.0

Signed-off-by: falkTX <falktx@falktx.com>
Signed-off-by: falkTX <falktx@falktx.com>
Signed-off-by: falkTX <falktx@falktx.com>
Signed-off-by: falkTX <falktx@falktx.com>
@michaelwillis michaelwillis merged commit 635322c into michaelwillis:HiDPI Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants