-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom upd #31
Comments
|
Merged
released as |
Thanks, that's super helpful. Appreciate the quick turnaround. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
My company's KDB team has a non standard 'upd' call that will push more than two values.
You have the following code in your node-q library:
if (err === undefined && Array.isArray(o) && o[0] === "upd") { self.emit('upd', o[1], o[2]); }
Can this be changed to:
if (err === undefined && Array.isArray(o) && o[0] === "upd") { events.EventEmitter.prototype.emit.apply(self, o); }
or simply
self.emit(...o);
since pretty much every version of node today supports that syntax.Basically allowing the array to be a variable length??
The text was updated successfully, but these errors were encountered: