Update for Teamspeak version 3.1 #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Teamspeak 3.1 API version
Updated use of getPluginPath to new 21 API
This was referenced Aug 26, 2016
Ugly hack but workz
|
Added the hack to support <v21 |
|
Btw @michail-nikolaev if you want to update to VS 2015 you need to remove the /Fx flag. |
Indentation from 15 to 19 was weird
As all apiVersion downgrades are handled by my code anyway. We can safely increment the default version. As any unhandled versions are newer anyway.
|
Just did a successful compile for #1098 but didnt test the plugin in Teamspeak 3.1 yet. But just assuming its working fine. |
|
Needs testing
Tested enough. Should be fine to go to testing branch |
|
Merged to correct branch in #1118 |
dedmen
added a commit
that referenced
this pull request
Jun 17, 2019
Added Teamspeak 3.1 support Former-commit-id: 2817122f9699f5a3a7d0a62844bb02b8a906dae4 [formerly 74d0ef9f93d5034aeddba2740cf9b6c4bb1b6afe] [formerly 45be63773e30419998540ba819e1ba96cac04053 [formerly 1015992f08b51a217a7d41ee505699284edc27a7]] [formerly aade9305194b11474a509e8e8cb83bc6d75cdcec [formerly 85ed61b03e6e50d89c6cd58744d3b8b3cbfd4ba2] [formerly 9e10d3e0db5a4f75cee8af374b692295c7aaa098 [formerly 28069cd8e364061873268c8f1a0bd367e48b2dfb]]] Former-commit-id: 5d5ca18ae5f291f9cbf5e56dee0e67fdd9e10826 [formerly b3e2daaae5baf4c2ecd1219f042764a63aa27522] [formerly a60c97d1aa786c5858dacd15941966908ae87df2 [formerly e6227d0df25b868120440be3fd3c692419aebf8c]] Former-commit-id: bb6eb340a73be9e8ae33564eebb5aa87f03077a8 [formerly 883f2e24c640d7604f72e3542205bee8e659fdf3] Former-commit-id: 42cb66b9b110485b4622208d83dc72e5fe039ece
dedmen
added a commit
that referenced
this pull request
Jun 17, 2019
Added Teamspeak 3.1 support Former-commit-id: a8ae94549e545a3941b85e3e0876e42da55fe529 [formerly dd4fe5096119eb5754391edda396e14c2b990e13] [formerly 7d93d3541ba389268f0721357281e74ee73ae806 [formerly 1521d196fbc2dfc140a3e42c28ba1b06c175d297]] [formerly fd1b5478778bdd677f58e172ff4aa4b30c75e63b [formerly 2d9e4470bfb788a84d90a39f89a0f64f05b780f9] [formerly a2bafbfdddcd18fd8061c6281eef0d0754c9bce1 [formerly a013ca901b666cf76e5b63958c7158d5498d7c29]]] Former-commit-id: fbdac3adef4ebe0a134e6bce855d99beacda06c0 [formerly ecbc5749bacdfff384bb2c0527fc635ccfc7c922] [formerly fba9b6985173fb420f4c4034f9617b25a198f60b [formerly 6598a299b7126daf072b7665f9691c1d3a115dea]] Former-commit-id: 92c41e1cfcfb0c658bf1e3dd14d85de88ad97c08 [formerly 32449eceaac7195412e9fb9a1cd4d5719ec14b6a] Former-commit-id: 365a5cae17261a650d279d5ee186ecbf12cc49eb
dedmen
added a commit
that referenced
this pull request
Jun 17, 2019
Added Teamspeak 3.1 support Former-commit-id: 2817122f9699f5a3a7d0a62844bb02b8a906dae4 [formerly 74d0ef9f93d5034aeddba2740cf9b6c4bb1b6afe] [formerly 45be63773e30419998540ba819e1ba96cac04053 [formerly 1015992f08b51a217a7d41ee505699284edc27a7]] [formerly aade9305194b11474a509e8e8cb83bc6d75cdcec [formerly 85ed61b03e6e50d89c6cd58744d3b8b3cbfd4ba2] [formerly 9e10d3e0db5a4f75cee8af374b692295c7aaa098 [formerly 28069cd8e364061873268c8f1a0bd367e48b2dfb]]] Former-commit-id: 5d5ca18ae5f291f9cbf5e56dee0e67fdd9e10826 [formerly b3e2daaae5baf4c2ecd1219f042764a63aa27522] [formerly a60c97d1aa786c5858dacd15941966908ae87df2 [formerly e6227d0df25b868120440be3fd3c692419aebf8c]] Former-commit-id: bb6eb340a73be9e8ae33564eebb5aa87f03077a8 [formerly 883f2e24c640d7604f72e3542205bee8e659fdf3] Former-commit-id: 42cb66b9b110485b4622208d83dc72e5fe039ece Former-commit-id: 16c19d9
dedmen
added a commit
that referenced
this pull request
Jun 17, 2019
Added Teamspeak 3.1 support Former-commit-id: a8ae94549e545a3941b85e3e0876e42da55fe529 [formerly dd4fe5096119eb5754391edda396e14c2b990e13] [formerly 7d93d3541ba389268f0721357281e74ee73ae806 [formerly 1521d196fbc2dfc140a3e42c28ba1b06c175d297]] [formerly fd1b5478778bdd677f58e172ff4aa4b30c75e63b [formerly 2d9e4470bfb788a84d90a39f89a0f64f05b780f9] [formerly a2bafbfdddcd18fd8061c6281eef0d0754c9bce1 [formerly a013ca901b666cf76e5b63958c7158d5498d7c29]]] Former-commit-id: fbdac3adef4ebe0a134e6bce855d99beacda06c0 [formerly ecbc5749bacdfff384bb2c0527fc635ccfc7c922] [formerly fba9b6985173fb420f4c4034f9617b25a198f60b [formerly 6598a299b7126daf072b7665f9691c1d3a115dea]] Former-commit-id: 92c41e1cfcfb0c658bf1e3dd14d85de88ad97c08 [formerly 32449eceaac7195412e9fb9a1cd4d5719ec14b6a] Former-commit-id: 365a5cae17261a650d279d5ee186ecbf12cc49eb Former-commit-id: 006ea6b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is not that clean.. the change to getPluginPath actually breaks compatability for older API versions.. I can implement a workaround for that.. which would add about 4 more lines of code to that area. Tell me if you are fine with that. Other solution would be to just not support any older versions. Which i wouldnt like.. because.. I dont like updating Teamspeak because I keep finding exploits for it.. There is a new crash exploit for the 3.1 client already.. and its still in beta...
Notes for workaround:
grab getPluginPath as ptr and wrap into ptr for
void (getPluginPath)(char path, size_t maxLen);
if API version returned by ts3plugin_apiVersion() < 21