Fix integration tests #10

snapshotpl · 2021-07-13T15:58:30Z

No description provided.

snapshotpl · 2021-07-13T16:55:50Z

I have fixed all possible errors and failures in integration test. Last thing I cant fix is enable courier in sandbox account, so 5 tests didn't pass.

michalbiarda · 2021-07-13T16:59:53Z

@snapshotpl You need to write to InPost support and ask them to enable courier on your Sandbox account. That's how I did.

Thanks for the fixes, I'll review them in free time. The Sandbox is unfortunately pretty unstable 😔.

michalbiarda

Could you please answer my question in review and refactor one of your fixes? I'll try to check later the last issue.

michalbiarda · 2021-07-13T18:04:15Z

tests/Integration/Client/TestCase.php

@@ -49,7 +49,12 @@ protected function assertSuccessWithFile(Response $response, DataTransferObject
    {
        if (!$response->getSuccess()) {
            $this->debug(print_r($response->getPayload()->toArray(), true));
+
+            if ($response->getPayload()->status === 500) {


@snapshotpl In what cases did you encounter 500 errors?

shipx-php-sdk/tests/Integration/Client/ReportResourceTest.php

Line 18 in cbdd3ab

public function testGetCodSuccessfulCall(): void

Do you encounter this 500 error every time you perform a request? I have never had issues with this one, nor do I have it now...

I would rather not skip test because of 500 error. Such mechanism might hide some real issues in the future.

src/Model/Error.php

michalbiarda · 2021-07-13T19:45:13Z

src/Response/HttpResponseProcessor/ErrorProcessor.php

-                    'message' => $data['error']
+                    'status' => $data['status'] ?? $httpResponse->getStatusCode(),
+                    'error' => $data['key'] ?? '',
+                    'message' => $data['error'] ?? '',


@snapshotpl This three lines of changes are unnecessary. Existence of status, key and error is already checked in if condition.

michalbiarda · 2021-07-13T19:56:38Z

src/Response/HttpResponseProcessor/ErrorProcessor.php

-                    'message' => $data['error']
+                    'status' => $data['status'] ?? $httpResponse->getStatusCode(),
+                    'error' => $data['key'] ?? '',
+                    'message' => $data['error'] ?? '',


@snapshotpl These three lines of changes are unnecessary. Existence of status, error and message is already checked in if condition.

michalbiarda · 2021-07-13T19:57:51Z

src/Response/HttpResponseProcessor/ErrorProcessor.php

                ]);
            }
            return null;
        }
+        $data['status'] ??= $httpResponse->getStatusCode();


@snapshotpl Wow! I didn't know ??= operator 👍.

michalbiarda · 2021-07-13T20:02:05Z

src/Response/HttpResponseProcessor/ErrorProcessor.php

                ]);
            }
            return null;
        }
+        $data['status'] ??= $httpResponse->getStatusCode();
+        $data['error'] = $data['key'] ?? '';
+        $data['message'] = $data['error'] ?? '';


@snapshotpl The default (documented) error response has status, error, message and (optional) details. Please fill in message with error and error with key only if message doesn't exist.

I know the whole thing is stupid, but inconsistency of Inpost API is even more stupid 👎.

michalbiarda · 2021-07-13T20:05:31Z

tests/Integration/Client/TestCase.php

@@ -49,7 +49,12 @@ protected function assertSuccessWithFile(Response $response, DataTransferObject
    {
        if (!$response->getSuccess()) {
            $this->debug(print_r($response->getPayload()->toArray(), true));
+
+            if ($response->getPayload()->status === 500) {


Do you encounter this 500 error every time you perform a request? I have never had issues with this one, nor do I have it now...

I would rather not skip test because of 500 error. Such mechanism might hide some real issues in the future.

michalbiarda · 2021-07-13T20:17:00Z

@snapshotpl When you're done with your work, please create a merge request to integration-tests-issues branch. I'll then handle the last issues and then merge it to master. Thanks!

snapshotpl · 2021-07-14T13:29:19Z

After enable courier on my sandbox account only one test fails:

1) MB\ShipXSDK\Test\Integration\Client\ShipmentResourceTest::testSuccessfulSimpleFlow
Failed asserting that false is true.

/shipx-php-sdk/tests/Integration/Client/TestCase.php:54
/shipx-php-sdk/tests/Integration/Client/ShipmentResourceTest.php:393
/shipx-php-sdk/tests/Integration/Client/ShipmentResourceTest.php:109

snapshotpl · 2021-08-23T19:16:00Z

@michalbiarda ping :-)

snapshotpl · 2021-11-12T13:34:47Z

@michalbiarda Can I help somehow with this release?

michalbiarda · 2021-12-19T13:09:21Z

@snapshotpl Unfortunately I have to abandon this project due to lack of time for development / maintenance :-(. I'm sorry.

snapshotpl · 2021-12-19T13:13:59Z

@michalbiarda understand. Can I take this code and move forward my own namespace?

michalbiarda · 2021-12-19T13:19:08Z

@snapshotpl Please do whatever you want with the code. Just put a link to this repo in your readme and mention me there. Hope you'll have time to finish it and maintain it. There's not much left I think :-).

snapshotpl added 4 commits July 13, 2021 17:44

Fix integration tests

f37b711

Skip 500 errors

0c32a43

Rollback date

ef7ece7

Fix DTO

db4eb5e

michalbiarda requested changes Jul 13, 2021

View reviewed changes

Restore Error model

3cb0bbb

snapshotpl requested a review from michalbiarda July 13, 2021 19:08

michalbiarda requested changes Jul 13, 2021

View reviewed changes

snapshotpl changed the base branch from master to integration-tests-issues July 14, 2021 13:27

Post CR improvments and remove skip 500 responses

036b776

snapshotpl requested a review from michalbiarda July 14, 2021 13:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix integration tests #10

Fix integration tests #10

snapshotpl commented Jul 13, 2021

snapshotpl commented Jul 13, 2021

michalbiarda commented Jul 13, 2021

michalbiarda left a comment

michalbiarda Jul 13, 2021

snapshotpl Jul 13, 2021

michalbiarda Jul 13, 2021

michalbiarda Jul 13, 2021

michalbiarda Jul 13, 2021

michalbiarda Jul 13, 2021

michalbiarda Jul 13, 2021

michalbiarda Jul 13, 2021

michalbiarda commented Jul 13, 2021

snapshotpl commented Jul 14, 2021

snapshotpl commented Aug 23, 2021

snapshotpl commented Nov 12, 2021

michalbiarda commented Dec 19, 2021

snapshotpl commented Dec 19, 2021

michalbiarda commented Dec 19, 2021

Fix integration tests #10

Are you sure you want to change the base?

Fix integration tests #10

Conversation

snapshotpl commented Jul 13, 2021

snapshotpl commented Jul 13, 2021

michalbiarda commented Jul 13, 2021

michalbiarda left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

michalbiarda commented Jul 13, 2021

snapshotpl commented Jul 14, 2021

snapshotpl commented Aug 23, 2021

snapshotpl commented Nov 12, 2021

michalbiarda commented Dec 19, 2021

snapshotpl commented Dec 19, 2021

michalbiarda commented Dec 19, 2021