Skip to content

Commit

Permalink
Update comment in Unit test to reflect FSAN state
Browse files Browse the repository at this point in the history
  • Loading branch information
michalbiesek committed Jul 11, 2023
1 parent 73a92c6 commit bbb67f2
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 19 deletions.
12 changes: 0 additions & 12 deletions test/unit/library/evtutilstest.c
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,6 @@
#include "test.h"
#include "scopestdlib.h"

// There isn't a lot of logic to test here unless we want to inject errors
// in malloc/calloc. I don't think this is super useful at this time.
//
// What *is* super useful is running this test with memory leak analysis
// compiled in:
// make FSAN=1 libtest
// LD_LIBRARY_PATH=contrib/build/cmocka/src/ test/linux/evtutilstest
//
// Hopefully it goes without saying that there should never be any leaks
// with this test.


static void
evtProtoAllocHttp1AndFree(void **state) {
protocol_info *proto = evtProtoAllocHttp1(TRUE);
Expand Down
5 changes: 0 additions & 5 deletions test/unit/library/httpmatchtest.c
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,6 @@
#include "scopestdlib.h"
#include "test.h"


// make FSAN=1 libtest
// LD_LIBRARY_PATH=contrib/build/cmocka/src/ test/linux/httpmatchtest


#define NET_ENTRIES 1024
net_info *g_netinfo = NULL;
list_t *g_extra_net_info_list = NULL;
Expand Down
2 changes: 0 additions & 2 deletions test/unit/library/test.c
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
* See details in:
* https://github.com/google/sanitizers/wiki/AddressSanitizerIncompatiblity
*
* make FSAN=1 libtest allows to instrument library unit test code
*
* The memory leak instrumentation is done by "-fsanitize=address"
*/

Expand Down

0 comments on commit bbb67f2

Please sign in to comment.