(feat) Raise if server unexpectedly closes #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalc
force-pushed
the
unexpected-close
branch
2 times, most recently
from
9432878
to
c8441b2
Compare
Unsure if this is good for all cases, but I suspect _not_ swallowing exceptions unless absolutely required is a better place to start in terms of responding to errors later.
michalc
force-pushed
the
unexpected-close
branch
from
c8441b2
to
70de2e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsure if this is good for all cases, but I suspect not swallowing exceptions
unless absolutely required is a better place to start in terms of responding to
errors later.