Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix android event emitter warnings #202

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Fix android event emitter warnings #202

merged 1 commit into from
Oct 11, 2022

Conversation

michalchudziak
Copy link
Owner

Overview

Fixes: #195
Added missing method stubs required by RCTEventEmitter that were missing on Android.

Test Plan

  • iOS example works (new arch)
  • iOS example works (old arch)
  • Android example works (new arch)
  • Android example works (old arch)

@michalchudziak michalchudziak changed the title fix(event-emitter): add missing android stubs Fix android event emitter warnings Oct 11, 2022
@michalchudziak michalchudziak merged commit 6a8e7da into master Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dratwas dratwas dratwas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

new NativeEventEmitter() was called with a non null argument without the required "addListener" method.
2 participants
@michalchudziak @dratwas