Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect SpecificationResult generated by TranslatableSpecification #26

Closed
michalkowal opened this issue Aug 12, 2022 · 0 comments · Fixed by #27
Closed

Incorrect SpecificationResult generated by TranslatableSpecification #26

michalkowal opened this issue Aug 12, 2022 · 0 comments · Fixed by #27
Labels
Bug
Milestone
1.2.2

Comments

@michalkowal
Copy link
Owner

TranslatableSpecification overrides SpecificationResult generated by decorated specification.
Translatable specification should get original SpecificationResult and change only error message.
@michalkowal michalkowal added this to the 1.2.2 milestone Aug 12, 2022
michalkowal added a commit that referenced this issue Aug 13, 2022
@michalkowal
Add missing parameters to expected result of TranslatableSpecificatio…
c4d3a54 
…n tests (#26)
michalkowal added a commit that referenced this issue Aug 13, 2022
@michalkowal
Extend SpecificationResult by errors collection in parameter (#26)
2ee9bda
michalkowal added a commit that referenced this issue Aug 13, 2022
@michalkowal
Add additional tests for TranslatableSpecification with CompositeSpec…
48dc260 
…ification (#26)
michalkowal added a commit that referenced this issue Aug 13, 2022
@michalkowal
Implement TranslatableSpecification as IComplexSpecification and use …
445edf0 
…SpecificationResult from base specification (#26)
michalkowal added a commit that referenced this issue Aug 13, 2022
@michalkowal
Fix TranslationsIntegrationTests with new TranslatableSpecification i…
ba98277 
…mplementation (#26)
michalkowal added a commit that referenced this issue Aug 13, 2022
@michalkowal
Add new SpecificationResult constructors comments (#26)
4ceea1f
michalkowal added a commit that referenced this issue Aug 13, 2022
@michalkowal
Refactoring (#26)
9740a0c
@michalkowal michalkowal linked a pull request Aug 13, 2022 that will close this issue
26 incorrect specificationresult generated by translatablespecification #27
Merged
michalkowal added a commit that referenced this issue Aug 13, 2022
@michalkowal
Merge pull request #27 from michalkowal/26-incorrect-specificationres…
4a4b836 
…ult-generated-by-translatablespecification

incorrect specificationresult generated by translatablespecification (#26)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
1.2.2
1 participant
@michalkowal