Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main page #1

Merged
merged 15 commits into from Feb 1, 2017
Merged

Conversation

jasiek-net
Copy link
Contributor

No description provided.

.LSOverride

# Thumbnails
._*

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need each line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found this in gitignore generator, so I suppose it's ok :)

README.md Outdated
npm start # go to browser -> localhost:3000
```

[step by step tutorial](http://blog.tomduncalf.com/posts/setting-up-typescript-and-react/)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rm line 11


body {
margin: 0;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍕

<meta name="Keywords" content="motorcycle, rental, repair, tour, marketplace, community, global, local, private, worldwide, motocross, enduro, cafe racer, scrambler, chopper, bobber, brat style, adventure, braap" />
<link href="https://fonts.googleapis.com/css?family=Roboto:100,200,300,400|Loved+by+the+King" rel="stylesheet">
<link href="/assets/css/custom.css" rel="stylesheet">
<script src="https://use.fontawesome.com/8ab56a8e28.js"></script>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

script tutaj? Czy to ma sens?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's AwesomeFonts politics: you can't just get CDN link, you have to give your email and they send you this script, more here: http://fontawesome.io/get-started/

package.json Outdated
@@ -0,0 +1,42 @@
{
"name": "viking-garage-frontend",
"version": "1.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.0.1

}

public componentDidMount() {
this.loadMore();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps it should return a value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain? docs

setTimeout(() => this.setState({
data: this.state.data.concat(data),
loading: false,
}), 2000);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't we prefer to have it return something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I implemented this with Promises first, but then I decided to simplify it. It's just a fast mockup to show indicator.

rootEl
);
})
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new line EOF

"exclude": [
"node_modules"
]
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new line EOF

new webpack.HotModuleReplacementPlugin(),
new WebpackNotifierPlugin({ alwaysNotify: true }),
]
};

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new line EOF

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we need to specify sourcemaps here too? I saw them in the tsconfig.json

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added in webpack.config.js: devtool: 'source-map', now it works.

<img style={styles.image} src={item.img} alt={item.title} />
</GridTile>
))}
{mappedItems}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

</button>
)
}
{loader}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

targetOrigin={{horizontal: 'right', vertical: 'top'}}
iconButtonElement={iconButtonElement}
anchorOrigin={anchorOrigin}
targetOrigin={targetOrigin}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

};
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒

@michalmikolajczyk michalmikolajczyk merged commit e79b262 into michalmikolajczyk:master Feb 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants