-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.0.0-beta.13 missing index.es.js #245
Comments
Hi @kresli, right – it's missing in the |
@kresli I have just released |
I think you also need to add the |
Nice catch @cmfcmf, whoops! 🤦♂️ Fixed in |
These are from PixiJS v4 and they are conditionally used. See how an instance of Do you have any ideas how to fix it @kresli? On one hand I would prefer not to break compatibility with PixiJS v4, but on the other hand it is already 2 major versions behind and removing it would simplify some areas of the codebase. |
Could be those dynamically imported like import("mesh")? Just guessing here as I never did that UPDATE: that's a bad idea as dynamic import could be detected by bundler which will end up with the same issue |
do we really need to import them? As developer could install them as perDependency if necessary |
They are not imported per se, what is imported in source coude is: Perhaps it is the bundler (rollup) that changes the import for the |
For now, I'm using |
@kresli can you share more details please? |
sorry for the late reply.
I guess this need to be done for production too 🤔 |
I have trouble to use the package with
ViteJS
asindex.es.js
is missingThe text was updated successfully, but these errors were encountered: