Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Uuid Model for compatible with CI 4.5 #10

Merged
merged 3 commits into from
Apr 22, 2024
Merged

fix: Uuid Model for compatible with CI 4.5 #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ccd0fb7
fix: Uuid Model for compatible with CI 4.5
asnanmtakim Apr 22, 2024
2dcc6dc
fix: update minimum php version
asnanmtakim Apr 22, 2024
ce32e2e
fix: import 2 undefined classes
asnanmtakim Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/php.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:

strategy:
matrix:
php-versions: ['7.3', '7.4', '8.0']
php-versions: ['8.1']

steps:
- name: Checkout
Expand Down
4 changes: 3 additions & 1 deletion src/UuidModel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

use CodeIgniter\Database\Exceptions\DataException;
use CodeIgniter\Model;
use CodeIgniter\Database\ConnectionInterface;
use CodeIgniter\Validation\ValidationInterface;
use Michalsn\Uuid\Exceptions\UuidModelException;
use Michalsn\Uuid\Uuid;

Expand Down Expand Up @@ -281,7 +283,7 @@ protected function doFindColumn(string $columnName)
*
* @return array
*/
protected function doFindAll(int $limit = 0, int $offset = 0)
protected function doFindAll(int $limit = null, int $offset = 0)
{
$result = parent::doFindAll($limit, $offset);
// Convert UUID fields from byte if needed
Expand Down