fix: wrong custom event name for specific elements targeted events #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Out` custom events created for specific elements events handling via `data-aos-id` were named as `aos:in:specific-id` instead of `aos:out:specific-id`
|
+1 |
|
This is not fixed yet? |
|
Fix this please! |
|
Would love to see this committed |
|
Was this fixed? I'm thinking no as this wasn't updated since last year. |
|
Is there a way we can promote or vote on this so it gets reviewed and merged? I'd rather not attach an EventListener to each and every animation. |
|
This appears to still be an issue in |
|
For now I'm using https://www.npmjs.com/package/patch-package to patch the issue |
|
Main package not fixed yet, but fix works well! |
Nikhil27b
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
No previous issue, but as it's clearly a mistake, PR was created.
Your solution
aos:out:specific-idcustom events created for specific elements events handling viadata-aos-idattributes were wrongly named asaos:in:specific-idinstead ofaos:out:specific-id, just renamed it accordingly.