Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle 2.14 break #49

Closed
reaperdtme opened this issue Jun 22, 2016 · 10 comments
Closed

Gradle 2.14 break #49

reaperdtme opened this issue Jun 22, 2016 · 10 comments
Assignees

Comments

@reaperdtme
Copy link

ProgressLogger doesn't exist in the same class path (moved to gradle.internal) which I don't think is even importable anymore. Should probable just ditch ProgressLogger all together as of 2.14

@michel-kraemer
Copy link
Owner

Thanks I'll look into this.

Possible duplicate of #47

@reaperdtme
Copy link
Author

@michel-kraemer per the gradle guide, looks like we should be using the slf4j logger:

You can also hook into Gradle's logging system from within other classes used in the build (classes from the buildSrc directory for example). Simply use an SLF4J logger. You can use this logger the same way as you use the provided logger in the build script.

import org.slf4j.Logger
import org.slf4j.LoggerFactory

Logger slf4jLogger = LoggerFactory.getLogger('some-logger')
slf4jLogger.info('An info log message logged using SLF4j')

https://docs.gradle.org/current/userguide/logging.html

There also appears to be a logger available from org.gradle.api which may be of more use:

https://docs.gradle.org/current/javadoc/org/gradle/api/logging/package-summary.html

Particularly logger:

An extension to the SLF4J Logger interface, which adds the quiet and lifecycle log levels.

You can obtain a Logger instance using Logging.getLogger(Class) or Logging.getLogger(String). A Logger instance is also available through Project.getLogger(), Task.getLogger() and Script.getLogger().

michel-kraemer added a commit that referenced this issue Jun 25, 2016
@michel-kraemer
Copy link
Owner

I uploaded a new snapshot that should fix the issue. May I ask you to test it, so I can release a new version of the plugin?

Please use the following to apply the snapshot:

buildscript {
    repositories {
        jcenter()
        maven {
            url "https://oss.sonatype.org/content/repositories/snapshots/"
        }
    }
    dependencies {
        classpath 'de.undercouch:gradle-download-task:3.1.0-SNAPSHOT'
    }
}

apply plugin: 'de.undercouch.download'

Remove the plugin from your plugin section in the build file.

Thanks for your support!

@gesellix
Copy link

I can confirm that this change fixes my issue. How fast could you make a release?

@michel-kraemer
Copy link
Owner

How fast could you make a release?

I'm out of office until Friday. Sorry. Do you need it urgently or can you work with the snapshot for the time being?

@gesellix
Copy link

@michel-kraemer no pressure, it's not that urgent. Thanks for the quick feedback!

@michel-kraemer
Copy link
Owner

OK. Then I'll do it on the weekend, unless I find another issue (maybe related to #48).

@gesellix
Copy link

Fine for me, I can rely on a snapshot meanwhile.

@michel-kraemer
Copy link
Owner

Thanks. I'll release a new version in the next couple of days. I'm going to close this issue now.

@gesellix
Copy link

gesellix commented Jul 3, 2016

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants