Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gnome 41 support #1524

Closed
rudrab opened this issue Sep 26, 2021 · 24 comments · Fixed by #1531
Closed

Gnome 41 support #1524

rudrab opened this issue Sep 26, 2021 · 24 comments · Fixed by #1531
Assignees

Comments

@rudrab
Copy link

rudrab commented Sep 26, 2021

Hello developers,
Unlike many others, ewlsh's fork was working for me in gnome 40 (fedora 34).
But in gnome 41, fedora 35, its not working. I have changed metadata.json to 41, still, I am getting an error symbol. Everything else is fine, but intellihide, with mouse gesture to unhide the dash is not working atall.

@ronidee
Copy link

ronidee commented Sep 29, 2021

Not working at all under Debian bookworm/sid, GNOME 40.4, Wayland.
Marked as outdated on it's extensions.gome.org/ webpage.

Any workaround or alternative addon (dashtopanel isn't an alternative for me :p) is greatly appreciated as well.

@vsv
Copy link

vsv commented Oct 1, 2021

I've made ewlsh's fork working for me by replacing AppIconMenu with AppMenu in the codebase:

ewlsh-gnome-41.patch.txt

@ronidee
Copy link

ronidee commented Oct 2, 2021

Sorry, apparently I'm kinda in the dark about this. What exactly is ewlsh's fork? Does his/her fork have more features, or just higher stability?
Can I apply this patch also to this fork?

Thanks a lot for sharing your solution though! I will try this out tomorrow.

@vsv
Copy link

vsv commented Oct 2, 2021

By "ewlsh's fork" I mean this pull request: #1402 . For the majority of the users, it makes dash-to-dock work with Gnome 40; there are some bugs, however, which prevent it from being merged yet.

I've also discovered another fork of that fork, which solves the issues specifically with Gnome 41: https://github.com/frantisekz/dash-to-dock/tree/fzatlouk/gnome-41 . So if you need to get dash-to-dack working asap and cannot wait until everything is merged and released properly, the best course of action is the following:

  1. Please ensure that you have sassc installed
  2. Grab the sources of the fork and install the extension manually:
git clone https://github.com/frantisekz/dash-to-dock.git
cd dash-to-dock
git switch fzatlouk/gnome-41
make
make install

@ewlsh ewlsh changed the title gnome 41 support GNOME 41 Support Oct 5, 2021
@ewlsh ewlsh changed the title GNOME 41 Support Gnome 41 support Oct 5, 2021
@ewlsh ewlsh pinned this issue Oct 5, 2021
@3v1n0 3v1n0 self-assigned this Oct 6, 2021
@maxborowsky
Copy link

Thx, @vsv

I've made ewlsh's fork working for me by replacing AppIconMenu with AppMenu in the codebase:

ewlsh-gnome-41.patch.txt

DTD works for me in GNOME 41 (Fedora 35 beta) with this patch, but right-clicking now does not call up the standard menus for application icons in the dock.

@slacka
Copy link

slacka commented Oct 10, 2021

The patch.txt works for me in GNOME 41 on openSUSE Tumbleweed. Been running for a few days now. The only major issue is lack of right-click on the dock apps.

@maxborowsky
Copy link

maxborowsky commented Oct 11, 2021

I tried to install fork https://github.com/frantisekz/dash-to-dock/tree/fzatlouk/gnome-41 instead ewlsh-gnome-41.patch.txt

No icon menu problems anymore, but there was another problem: click action "Minimize or show preview" for multiple windows of the same application not work correctly, preview can only be associated with another action, for example middle-click.

And the old problem has not been solved - trash icon and CD icon periodically switch places.

3v1n0 added a commit to 3v1n0/dash-to-dock that referenced this issue Oct 11, 2021
Upstream gnome-shell is using now a new AppMenu class for application
menus, but we're customizing enough already so it's just better to have
our own implementation for now so that can work in both 40 and 41.

Also updated base code to match latest upstream

Fixes: micheleg#1524
3v1n0 added a commit to 3v1n0/dash-to-dock that referenced this issue Oct 11, 2021
@3v1n0 3v1n0 linked a pull request Oct 11, 2021 that will close this issue
@3v1n0
Copy link
Collaborator

3v1n0 commented Oct 11, 2021

I've been looking at trying to reuse the suggested patches, but sadly we can't use them, because we can't easily just inherit from AppMenu (see link below for more infos) or we'd lose various features (isolation, devices support, previews in right-click...).

So this is now handled in a new MR (#1531).

@xaluxs
Copy link

xaluxs commented Oct 17, 2021

version 70 is not working now Help !!

@riffer33
Copy link

erick-alvz - Gnome seems to automatically update extensions now, at least on my solus install, so it might have "updated" to the latest version on the extension website. ergo the fzatlouk version I was using is gone. I'm just looking into stopping the automatic updating now.

@xaluxs
Copy link

xaluxs commented Oct 19, 2021

@riffer33 did you manage to stop the automatic update?

@mmm8955405
Copy link

erick-alvz - Gnome seems to automatically update extensions now, at least on my solus install, so it might have "updated" to the latest version on the extension website. ergo the fzatlouk version I was using is gone. I'm just looking into stopping the automatic updating now.

At present, I can't find a way to cancel the automatic update. After logging in, it will be automatically updated to 70, which is very sad

@mmm8955405
Copy link

“ewlsh 的叉子”是指这个拉取请求: #1402 。 对于大多数用户来说,它使 Dash-to-dock 与 Gnome 40 一起工作; 然而,有一些错误阻止它被合并。

我还发现了该分叉的另一个分叉,它专门解决了 Gnome 41 的问题: : https //github.com/frantisekz/dash-to-dock/tree/fzatlouk/gnome-41 。 因此,如果您需要尽快使 dash-to-dack 工作并且不能等到所有内容都正确合并和发布,最好的行动方案如下:

1. 请确保您有  `sassc`已安装

2. 获取 fork 的来源并手动安装扩展:
git clone https://github.com/frantisekz/dash-to-dock.git
cd dash-to-dock
git switch fzatlouk/gnome-41
make
make install

Why can't you provide CSS and need sassc compilation???

@maxborowsky
Copy link

@mmm8955405

Why can't you provide CSS and need sassc compilation???

You will get CSS if you take a ready made extension from the GNOME Shell Extensions site, but this is GitHub, here developers provide access to the source code.

@vsv
Copy link

vsv commented Oct 19, 2021

At present, I can't find a way to cancel the automatic update

You can "block" automatic updates by bumping "version" field to 71 in "~/.local/share/gnome-shell/extensions/dash-to-dock@micxgx.gmail.com/metadata.json"

@mmm8955405
Copy link

@mmm8955405

Why can't you provide CSS and need sassc compilation???

You will get CSS if you take a ready made extension from the GNOME Shell Extensions site, but this is GitHub, here developers provide access to the source code.

Is CSS not the source code? Only less and sass are the source code? I write a java program that does not provide class bytecode, but only the source code. Then let other people who can't Java compile, is that right?

@mmm8955405
Copy link

At present, I can't find a way to cancel the automatic update

You can "block" automatic updates by bumping "version" field to 71 in "~/.local/share/gnome-shell/extensions/dash-to-dock@micxgx.gmail.com/metadata.json"

Thank you very much. I've switched back to version 40

@mmm8955405
Copy link

This is a good place. Thank you very much for the help of many elite programmers

@maxborowsky
Copy link

@mmm8955405

Is CSS not the source code? Only less and sass are the source code? (...)

Please, read this:
https://developer.mozilla.org/en-US/docs/Glossary/CSS_preprocessor

@mmm8955405
Copy link

@mmm8955405

Is CSS not the source code? Only less and sass are the source code? (...)

Please, read this: https://developer.mozilla.org/en-US/docs/Glossary/CSS_preprocessor

I have done front-end work and understand these technologies very well. It's just that it's not difficult for you to provide CSS. There is also less work for users. Some users don't go to Gnome shell to download, but prefer to download on GitHub.

Thank you for your quick answer. I admire it very much. Now my desktop can compile and work normally. Thank you very much.

@thwaller
Copy link

I just did sudo dnf install gnome-shell-extension-dash-to-dock and it worked, even autohide

On which OS and version, which version of GNOME?

@maxborowsky
Copy link

@mmm8955405

Some users don't go to Gnome shell to download, but prefer to download on GitHub.

But such users actually take on the voluntary work of beta testers. What you take with GitHub is not the final release that the authors found suitable for all users. GitHub this is primarily a place for development, a tool for sharing ideas open source. We must respect the work of authors who provide us with wonderful applications for free.

micheleg pushed a commit that referenced this issue Oct 24, 2021
Upstream gnome-shell is using now a new AppMenu class for application
menus, but we're customizing enough already so it's just better to have
our own implementation for now so that can work in both 40 and 41.

Also updated base code to match latest upstream

Fixes: #1524
micheleg pushed a commit that referenced this issue Oct 24, 2021
@ewlsh ewlsh unpinned this issue Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

12 participants