locations: Fix missing behaviour for volume backed locations #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I forgot to add this originally. Without it, we don't know that the icon is a location rather than an app, and some undesired items are added to the menu. Mount icons already had this set and didn't have a problem. Fixes micheleg#1037
This is another spot where I added logic to mount handling and forgot to add it for volumes too. We don't want to show network locations, so we need to filter out both volumes and mounts. Fixed micheleg#1031
philipl
changed the title
|
Added an additional commit that fixes certain network backed locations appearing in the dock when they should not. @3v1n0 should be merged for ubuntu-dock too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to add this originally. Without it, we don't know that
the icon is a location rather than an app, and some undesired items
are added to the menu.
Mount icons already had this set and didn't have a problem.
Fixes #1037