Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intellihide: add dropdown menu to handled window types #2014

Merged
merged 1 commit into from
May 29, 2023

Conversation

taoky
Copy link
Contributor

@taoky taoky commented May 20, 2023

This is a workaround for issue #2013. As far as I could tell this works in most cases of popup menus (by right clicks) in GNOME wayland session. The only exception I meet is the multilevel popup menu from Telegram (illustrated in #2013), but with showing urgent notifications off it also works without problems.

Meta.WindowType.POPUP_MENU is not added to this list as I find that it has side effects for Qt xwayland programs: on my machine the intellihide is triggered every time I right-clicked in Okular (xwayland). However I could not reproduce this within my GNOME OS VM so it might be caused by other factors.

@taoky
Copy link
Contributor Author

taoky commented May 22, 2023

Just tested this in GNOME Xorg session, and confirmed that this PR will not change the behavior of dock in Xorg: menus are still above the dock and they are clickable.

Copy link
Collaborator

@vanvugt vanvugt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works for me.

@vanvugt vanvugt merged commit 810c1a5 into micheleg:master May 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants