dash: Use a different container to hold floating ShowAppsIcon #2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a floating show apps icon setup, it needs to be at the same level of the dash box, but we can't use the same container because upstream code only uses that for application icons, and this assumption may break things such as DnD and potentially other things. So move things in a new container. Closes: micheleg#2010
3v1n0
force-pushed
the
rearrange-fix-icons
branch
from
eafe402
to
8e0cf3a
Compare
The separator may be wrongly computed as an extra icon item, causing new items being positioned in the wrong place. This is clearly visible when running a new application, that ends up being added as the one before the last one, instead of as the last one. By temporary removing the separator element we avoid having to consider the special case all the times when doing the icons positioning math, instead we can just add it back once we're done. See: micheleg#2010 (comment) LP: #2017523
Just get the actual number of icons we've in the box minus the ones we're going to remove. So that our math is right about when to show the separator
Use better syntax
3v1n0
force-pushed
the
rearrange-fix-icons
branch
from
8e0cf3a
to
d5e6eea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a floating show apps icon setup, it needs to be at the same level of the dash box, but we can't use the same container because upstream code only uses that for application icons, and this assumption may break things such as DnD and potentially other things.
So move things in a new container.
Closes: #2010