docking: Update dock visibility after overview hide animation is done #2056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the overview was closed by clicking on the dash, and the cursor left the dash before the animation finished, the dock would still be visible after it should also be hidden. Updating the dock visibility ensures the visibility isn't impacted by ignored signals during the animation.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the overview was closed by clicking on the dash, and the cursor left the dash before the animation finished, the dock would still be visible after it should also be hidden.
Updating the dock visibility ensures the visibility isn't impacted by ignored signals during the animation.
I couldn't see any open issues for this, and since it was a simple fix I just made a PR instead of an issue. If I've missed the open issues, I can add them to the commit message if required :)