Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show error messages when disabling #2237

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

sergio-costas
Copy link
Collaborator

Since the destroy() function can be called several times, it is paramount to don't call objects that have been freed in previous calls.

Since the destroy() function can be called several times, it is
paramount to don't call objects that have been freed in
previous calls.
@sergio-costas
Copy link
Collaborator Author

@3v1n0 And this one too, please?

@vanvugt
Copy link
Collaborator

vanvugt commented Jun 27, 2024

What are the error messages? Have they been reported as bugs in Launchpad or here?

@sergio-costas
Copy link
Collaborator Author

Mmm... odd... now I can't reproduce them... But they were messages that said that undefined hasn't a destroy() method.

@sergio-costas
Copy link
Collaborator Author

Anyway, if you check the lines 2535 to 2540, before calling destroy() it checks if the variable is NULL or not, because it is being set to NULL right after calling the method.

@sergio-costas
Copy link
Collaborator Author

And it does my way in other lines of the same method too:
imagen

@vanvugt vanvugt merged commit 88a1160 into micheleg:master Jun 28, 2024
1 check passed
@3v1n0
Copy link
Collaborator

3v1n0 commented Jul 2, 2024

Thanks, in theory we should not call it multiple times, but it's not a problem to be protected by that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants