Initial support for 'com.canonical.Unity.LauncherEntry' APIs #590

azzar1 · 2017-09-05T17:26:41Z

Initial support to 'com.canonical.Unity.LauncherEntry' APIs. At the moment it only supports the badge notification. The code can be tested using the following script: http://paste.ubuntu.com/25473314/

micheleg · 2017-09-06T01:02:31Z

appIcons.js

+        if (count <= 9999) {
+            return count.toString();
+        } else if (count < 10**5) {
+            let thousands = count / 10**3;


Quick observation: the 10**x syntax is not supported on gjs version of my system (Debian Stretch, Gnome 3.22). For retrocompatibily -- so far I have been supporting 3.18--3.24 with the same codebase -- better stick to 1ex format form the moment.

micheleg · 2017-09-06T01:04:19Z

launcherAPI.js

+        }
+    },
+
+    setDBusName(dbusName) {


Missing 'function'. Again, it might work in the latest js but it doesn't on my system.

micheleg · 2017-09-06T01:08:50Z

Hi Andrea, thanks for the PR. I tried to run your code and and found a couple for minor incompatibilities (I left a couple fo comments here). I wasn't able to test the badges with your script because I don't have libunity on my system at the moment... I will try to have a closer look in the next few days.

azzar1 · 2017-09-06T08:04:15Z

Fixed thanks.

azzar1 · 2017-09-20T08:56:45Z

Any news?

azzar1 · 2017-09-20T11:11:05Z

I added support for progress bar too. The design is based on the one of Plank.

didrocks · 2017-09-20T13:18:14Z

@micheleg & @franglais125: sorry to bother you with this, but do you have a moment for a review on Andrea's work? This is the last dock modification we would like to have for 17.10, and as you know, the timeline is short (sorry to come late with this) ;) Now that both indicator numbers and progress bar are included, it would be great to have your opinion on this.

If you don't have time, we can cherry-pick on our dock branch for now, still ensuring it goes upstream afterwards, as you prefer :)

franglais125 · 2017-09-20T17:00:04Z

appIcons.js

+        let [surfaceWidth, surfaceHeight] = area.get_surface_size();
+        let cr = area.get_context();
+
+        iconSize = this.icon.iconSize * scaleFactor;


Missing let.

franglais125 · 2017-09-20T17:29:30Z

docking.js

@@ -1636,6 +1668,7 @@ var DockManager = new Lang.Class({
    Name: 'DashToDock.DockManager',

    _init: function() {
+        this._remoteModel = new LauncherAPI.LauncherEntryRemoteModel();


I don't know that it is strictly necessary, but this object is never destroyed.

In Line ~1921 we can add this._remoteModel.destroy();, since the .destroy() method is already available.

franglais125 · 2017-09-20T17:39:51Z

@azzar1 I got this running on 17.10. Nice work! Generally speaking, this is something that will only work in Ubuntu?

Unfortunately I run Debian, and I haven't found the libraries readily available.

@didrocks I will give it some testing (on 17.10) and see if I find problems/improvements. However, it's really up to @micheleg to plan the inclusion/path forward. Cheers!

franglais125 · 2017-09-20T17:46:40Z

launcherAPI.js

+            Gio.DBus.session.signal_unsubscribe(this._launcher_entry_dbus_signal_id);
+        }
+
+        if (this_._dbus_name_owner_changed_signal_id) {


Typo this_

azzar1 · 2017-09-20T23:26:05Z

Fixed.
Regarding the question "Generally speaking, this is something that will only work in Ubuntu?": Unfortunetly there is not a standard for this type of things, but most docks (like plank, etc.) supports the unity-api. It must be considered that using libunity is not compulsory as libunity is just a "wrapper" to easliy implement the required dbus interfaces.

micheleg · 2017-09-21T00:00:28Z

Sorry, I missed this conversation. Unfortunately I didn't find the time to look into this, beside my initial overview. What is your schedule? I should be able to give this a thorough look by the end of the weekend, but I can't promise I'll be able to review this in time. Thus you might want to cherry-pick all these commits in your branch. In any case I confirm I'm intentioned to merge this feature in master as soon as possible, to avoid diverging between the two branches. My only concern was about introducing dependencies on Ubuntu specific libraries, but from the overview of the code it didn't seem to be the case. Can you confirm this? On 21 Sep 2017 00:26, "Andrea Azzarone" <notifications@github.com> wrote: Fixed. Regarding the question "Generally speaking, this is something that will only work in Ubuntu?": Unfortunetly there is not a standard for this type of things, but most docks (like plank, etc.) supports the unity-api. It must be considered that using libunity is not compulsory as libunity is just a "wrapper" to easliy implement the required dbus interfaces. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#590 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABo0PsHcsXDWAnAzj0kgzgS_KfzSCgclks5skZ8NgaJpZM4PNRYm> .

azzar1 · 2017-09-21T11:25:24Z

It does not use ubuntu specific libraries. Everything is based on dbus.

micheleg · 2017-09-21T11:32:21Z

Ok, that was indeed my understanding. On 21 Sep 2017 12:25, "Andrea Azzarone" <notifications@github.com> wrote: It does not use ubuntu specific libraries. Everything is based on dbus. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#590 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABo0PhzEN2o_MeORWLGquY9zhQ6B8jOxks5skkelgaJpZM4PNRYm> . On 21 Sep 2017 12:25, "Andrea Azzarone" <notifications@github.com> wrote: It does not use ubuntu specific libraries. Everything is based on dbus. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#590 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABo0PhzEN2o_MeORWLGquY9zhQ6B8jOxks5skkelgaJpZM4PNRYm> . On 21 Sep 2017 12:25, "Andrea Azzarone" <notifications@github.com> wrote: It does not use ubuntu specific libraries. Everything is based on dbus. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#590 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABo0PhzEN2o_MeORWLGquY9zhQ6B8jOxks5skkelgaJpZM4PNRYm> .

franglais125 · 2017-09-21T15:00:21Z

@azzar1 Is there a way of easily running the dbus wrapper without installing libunity? I'm not familiar with the code, browsing through the source I found the unity-launcher.vala file, where I think the necessary api's are defined, but I'm not entirely sure.

I'm asking to know how difficult it would be to have this available on other systems.

azzar1 · 2017-09-22T11:51:40Z

@franglais125 you need to implement inside the application a dbus server exporting the required interface with the wanted properties. libunity just does this. I don't have any code example but it's not complicated at all.

micheleg · 2017-09-24T12:11:51Z

I had a look at this. Overall I'm ok with it. I really need to rething the code organization ... but this is good enough for now. I've consolidated the history and made few cosmetic changes in the development branch. However, I could not check if this is working properly: I tried to use your script in a Ubuntu Artful virtual machine, but I could't see any notification badge, nor see any error. Any suggestion?

There's a couple of thing missing/tofix that probably do not directly affect the ubuntu side.

Ideally I need a settings to switch on/off the feature. I can add this later.
The way you set he default color of the badge. I'd keep a more agnostic one (maybe red) as a defualt. I think you should tweak it at the ubuntu theme level, rather than hardcode it here.This can be obviously an acceptable shortcut given your schedule.

If you confirm that the branch is indeed working, I'm happy to merge into master.

franglais125 · 2017-09-24T18:14:16Z

Here is a small thing to think about. I don't see it as a deal breaker, but still something that can be fixed:

Perhaps we can toggle the notifications when showing the number overlays?

Edit: something like this: franglais125@2e6e28c

azzar1 · 2017-09-25T13:47:54Z

@micheleg The branch is indeed working.

azzar1 · 2017-09-25T15:11:06Z

http://paste.ubuntu.com/25615125/ This a simple python script that can be used to test the code. This code does not uset libunity.

franglais125 · 2017-09-25T16:26:21Z

appIcons.js

+    },
+
+    insertEntryRemote: function(remote) {
+        if (!remote || this._remoteEntries.includes(remote))


@azzar1 I used your new script (thanks!), and got this running on Gnome 3.22.

This line is throwing an error for me, since Debian is still on mozJS 24.

Perhaps we can change includes (which is not supported until mozJS 52) with:

if (!remote || this._remoteEntries.indexOf(remote) !== -1)

franglais125 · 2017-09-25T16:27:47Z

appIcons.js

+    },
+
+    removeEntryRemote: function(remote) {
+        if (!remote || !this._remoteEntries.includes(remote))


Same here. includes -> indexOf

micheleg · 2017-09-25T20:42:44Z

I also manage to get the badges to work with your new script. I've merged the branch into master. I've only skipped the commit changing the default colour, which you might want to keep in the ubuntu-branch for the time being.

micheleg · 2017-09-25T21:25:17Z

I've seen you had already merged in the ubuntu branch and made a new release/announcement. Closing this pull request. Thanks for the contribution @azzar1 @didrocks @franglais125!

Reference to the commit in master: [5ef239d..a6fba76]

didrocks · 2017-09-26T12:47:09Z

Thanks a lot as usual @micheleg, @franglais125 to have make that easy for ubuntu! I think @azzar1 will help you once we release 17.10 to get the final options and touches done! ;)

gayanper · 2017-10-12T16:05:23Z

@micheleg Does the ubuntu feature (progress, badges) works on other distributions as well ? like antergos , fedora ?

azzar1 · 2017-10-12T17:28:40Z

If the application uses the unity launcher API yes. E.g. I didn't checked but electron apps should work.

…

On 12 Oct 2017 18:05, "gayanper" ***@***.***> wrote: @micheleg <https://github.com/micheleg> Does the ubuntu feature (progress, badges) works on other distributions as well ? like antergos , fedora ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#590 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADgbsc5sNUUS19w1kBfc4SXq2Ybykvm1ks5srjjEgaJpZM4PNRYm> .

ghost · 2019-02-12T01:02:04Z

man this looks so cool hope some day unity api will be in the aur for use on manjaro and arch

harry-cpp · 2019-11-20T11:32:53Z

The only thing missing from here is the urgency I would say (unity_launcher_entry_set_urgent).

azzar1 added 6 commits September 1, 2017 22:45

Implement a notification badge in MyAppIcon

23d293d

Ellipsize if the number is too big.

93358fa

Implement the dbus backed for the unity launcher api.

b67154f

remove .vscode directory

0027f74

Use var instead of const.

11113a2

Remove trailing whitespaces

b79ce26

micheleg reviewed Sep 6, 2017

View reviewed changes

Support older version of gjs.

52fa8b3

azzar1 mentioned this pull request Sep 6, 2017

Provide Unity Launcher API #591

Closed

This was referenced Sep 9, 2017

Progress on icons (merge from dash-to-dock) home-sweet-gnome/dash-to-panel#98

Closed

Indicator for unread messages home-sweet-gnome/dash-to-panel#126

Closed

Merge remote-tracking branch 'origin/master' into add-counters

4f628f5

micheleg mentioned this pull request Sep 17, 2017

Possibility to show count of unread messages in dock #595

Closed

azzar1 added 2 commits September 20, 2017 12:55

Support progress bar.

2bed1e1

Add drawRoundedLine to utils.js

b273d8c

franglais125 reviewed Sep 20, 2017

View reviewed changes

Minor changes after review

5a370bb

Change the default color

8932f87

franglais125 reviewed Sep 25, 2017

View reviewed changes

micheleg closed this Sep 25, 2017

harry-cpp mentioned this pull request Sep 25, 2017

Implement taskbar progressbar picoe/Eto#763

Closed

Feichtmeier mentioned this pull request Dec 10, 2017

Ubuntu 17.10 GNOME DE: no ICON badge for unread mails Foundry376/Mailspring#420

Closed

jnugh mentioned this pull request May 19, 2019

Unity Badge Count implementation electron/electron#16001

Closed

itsvic-dev mentioned this pull request Feb 10, 2021

[Feature request] Badges cyberos/cyber-dock#7

Open

evgen-p16 mentioned this pull request Sep 14, 2022

Notification counter not showing up home-sweet-gnome/dash-to-panel#1746

Closed

xalt7x mentioned this pull request Oct 20, 2022

Enhancement: Synthesise notification badges for most applications (using messageTray) #1861

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial support for 'com.canonical.Unity.LauncherEntry' APIs #590

Initial support for 'com.canonical.Unity.LauncherEntry' APIs #590

azzar1 commented Sep 5, 2017

micheleg Sep 6, 2017

micheleg Sep 6, 2017

micheleg commented Sep 6, 2017

azzar1 commented Sep 6, 2017

azzar1 commented Sep 20, 2017

azzar1 commented Sep 20, 2017

didrocks commented Sep 20, 2017

franglais125 Sep 20, 2017

franglais125 Sep 20, 2017

franglais125 commented Sep 20, 2017

franglais125 Sep 20, 2017

azzar1 commented Sep 20, 2017

micheleg commented Sep 21, 2017 via email

azzar1 commented Sep 21, 2017

micheleg commented Sep 21, 2017 via email

franglais125 commented Sep 21, 2017

azzar1 commented Sep 22, 2017

micheleg commented Sep 24, 2017

franglais125 commented Sep 24, 2017 •

edited

azzar1 commented Sep 25, 2017

azzar1 commented Sep 25, 2017

franglais125 Sep 25, 2017 •

edited

franglais125 Sep 25, 2017

micheleg Sep 25, 2017

micheleg commented Sep 25, 2017

micheleg commented Sep 25, 2017

didrocks commented Sep 26, 2017

gayanper commented Oct 12, 2017

azzar1 commented Oct 12, 2017 via email

ghost commented Feb 12, 2019

harry-cpp commented Nov 20, 2019

Initial support for 'com.canonical.Unity.LauncherEntry' APIs #590

Initial support for 'com.canonical.Unity.LauncherEntry' APIs #590

Conversation

azzar1 commented Sep 5, 2017

micheleg Sep 6, 2017

Choose a reason for hiding this comment

micheleg Sep 6, 2017

Choose a reason for hiding this comment

micheleg commented Sep 6, 2017

azzar1 commented Sep 6, 2017

azzar1 commented Sep 20, 2017

azzar1 commented Sep 20, 2017

didrocks commented Sep 20, 2017

franglais125 Sep 20, 2017

Choose a reason for hiding this comment

franglais125 Sep 20, 2017

Choose a reason for hiding this comment

franglais125 commented Sep 20, 2017

franglais125 Sep 20, 2017

Choose a reason for hiding this comment

azzar1 commented Sep 20, 2017

micheleg commented Sep 21, 2017 via email

azzar1 commented Sep 21, 2017

micheleg commented Sep 21, 2017 via email

franglais125 commented Sep 21, 2017

azzar1 commented Sep 22, 2017

micheleg commented Sep 24, 2017

franglais125 commented Sep 24, 2017 • edited

azzar1 commented Sep 25, 2017

azzar1 commented Sep 25, 2017

franglais125 Sep 25, 2017 • edited

Choose a reason for hiding this comment

franglais125 Sep 25, 2017

Choose a reason for hiding this comment

micheleg Sep 25, 2017

Choose a reason for hiding this comment

micheleg commented Sep 25, 2017

micheleg commented Sep 25, 2017

didrocks commented Sep 26, 2017

gayanper commented Oct 12, 2017

azzar1 commented Oct 12, 2017 via email

ghost commented Feb 12, 2019

harry-cpp commented Nov 20, 2019

franglais125 commented Sep 24, 2017 •

edited

franglais125 Sep 25, 2017 •

edited