Initial support for 'com.canonical.Unity.LauncherEntry' APIs #590

azzar1 · Sep 5, 2017

Initial support to 'com.canonical.Unity.LauncherEntry' APIs. At the moment it only supports the badge notification. The code can be tested using the following script: http://paste.ubuntu.com/25473314/

micheleg · Sep 6, 2017

micheleg reviewed Sep 6, 2017

View changes

Quick observation: the 10**x syntax is not supported on gjs version of my system (Debian Stretch, Gnome 3.22). For retrocompatibily -- so far I have been supporting 3.18--3.24 with the same codebase -- better stick to 1ex format form the moment.

micheleg · Sep 6, 2017

micheleg reviewed Sep 6, 2017

View changes

Missing 'function'. Again, it might work in the latest js but it doesn't on my system.

micheleg · Sep 6, 2017

Hi Andrea, thanks for the PR. I tried to run your code and and found a couple for minor incompatibilities (I left a couple fo comments here). I wasn't able to test the badges with your script because I don't have libunity on my system at the moment... I will try to have a closer look in the next few days.

azzar1 · Sep 6, 2017

Fixed thanks.

azzar1 · Sep 20, 2017

Any news?

azzar1 · Sep 20, 2017

I added support for progress bar too. The design is based on the one of Plank.

didrocks · Sep 20, 2017

@micheleg & @franglais125: sorry to bother you with this, but do you have a moment for a review on Andrea's work? This is the last dock modification we would like to have for 17.10, and as you know, the timeline is short (sorry to come late with this) ;) Now that both indicator numbers and progress bar are included, it would be great to have your opinion on this.

If you don't have time, we can cherry-pick on our dock branch for now, still ensuring it goes upstream afterwards, as you prefer :)

franglais125 · Sep 20, 2017

franglais125 reviewed Sep 20, 2017

View changes

Missing let.

franglais125 · Sep 20, 2017

franglais125 reviewed Sep 20, 2017

View changes

I don't know that it is strictly necessary, but this object is never destroyed.

In Line ~1921 we can add this._remoteModel.destroy();, since the .destroy() method is already available.

franglais125 · Sep 20, 2017

@azzar1 I got this running on 17.10. Nice work! Generally speaking, this is something that will only work in Ubuntu?

Unfortunately I run Debian, and I haven't found the libraries readily available.

@didrocks I will give it some testing (on 17.10) and see if I find problems/improvements. However, it's really up to @micheleg to plan the inclusion/path forward. Cheers!

franglais125 · Sep 20, 2017

franglais125 reviewed Sep 20, 2017

View changes

Typo this_

azzar1 · Sep 20, 2017

Fixed.
Regarding the question "Generally speaking, this is something that will only work in Ubuntu?": Unfortunetly there is not a standard for this type of things, but most docks (like plank, etc.) supports the unity-api. It must be considered that using libunity is not compulsory as libunity is just a "wrapper" to easliy implement the required dbus interfaces.

micheleg · Sep 21, 2017

Sorry, I missed this conversation. Unfortunately I didn't find the time to look into this, beside my initial overview. What is your schedule? I should be able to give this a thorough look by the end of the weekend, but I can't promise I'll be able to review this in time. Thus you might want to cherry-pick all these commits in your branch. In any case I confirm I'm intentioned to merge this feature in master as soon as possible, to avoid diverging between the two branches. My only concern was about introducing dependencies on Ubuntu specific libraries, but from the overview of the code it didn't seem to be the case. Can you confirm this? On 21 Sep 2017 00:26, "Andrea Azzarone" <notifications@github.com> wrote: Fixed. Regarding the question "Generally speaking, this is something that will only work in Ubuntu?": Unfortunetly there is not a standard for this type of things, but most docks (like plank, etc.) supports the unity-api. It must be considered that using libunity is not compulsory as libunity is just a "wrapper" to easliy implement the required dbus interfaces. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#590 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABo0PsHcsXDWAnAzj0kgzgS_KfzSCgclks5skZ8NgaJpZM4PNRYm> .

azzar1 · Sep 21, 2017

It does not use ubuntu specific libraries. Everything is based on dbus.

micheleg · Sep 21, 2017

Ok, that was indeed my understanding. On 21 Sep 2017 12:25, "Andrea Azzarone" <notifications@github.com> wrote: It does not use ubuntu specific libraries. Everything is based on dbus. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#590 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABo0PhzEN2o_MeORWLGquY9zhQ6B8jOxks5skkelgaJpZM4PNRYm> . On 21 Sep 2017 12:25, "Andrea Azzarone" <notifications@github.com> wrote: It does not use ubuntu specific libraries. Everything is based on dbus. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#590 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABo0PhzEN2o_MeORWLGquY9zhQ6B8jOxks5skkelgaJpZM4PNRYm> . On 21 Sep 2017 12:25, "Andrea Azzarone" <notifications@github.com> wrote: It does not use ubuntu specific libraries. Everything is based on dbus. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#590 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABo0PhzEN2o_MeORWLGquY9zhQ6B8jOxks5skkelgaJpZM4PNRYm> .

franglais125 · Sep 21, 2017

@azzar1 Is there a way of easily running the dbus wrapper without installing libunity? I'm not familiar with the code, browsing through the source I found the unity-launcher.vala file, where I think the necessary api's are defined, but I'm not entirely sure.

I'm asking to know how difficult it would be to have this available on other systems.

azzar1 · Sep 22, 2017

@franglais125 you need to implement inside the application a dbus server exporting the required interface with the wanted properties. libunity just does this. I don't have any code example but it's not complicated at all.

micheleg · Sep 24, 2017

I had a look at this. Overall I'm ok with it. I really need to rething the code organization ... but this is good enough for now. I've consolidated the history and made few cosmetic changes in the development branch. However, I could not check if this is working properly: I tried to use your script in a Ubuntu Artful virtual machine, but I could't see any notification badge, nor see any error. Any suggestion?

There's a couple of thing missing/tofix that probably do not directly affect the ubuntu side.

Ideally I need a settings to switch on/off the feature. I can add this later.
The way you set he default color of the badge. I'd keep a more agnostic one (maybe red) as a defualt. I think you should tweak it at the ubuntu theme level, rather than hardcode it here.This can be obviously an acceptable shortcut given your schedule.

If you confirm that the branch is indeed working, I'm happy to merge into master.

franglais125 · Sep 24, 2017

Here is a small thing to think about. I don't see it as a deal breaker, but still something that can be fixed:

Perhaps we can toggle the notifications when showing the number overlays?

Edit: something like this: franglais125/dash-to-dock@2e6e28c

azzar1 · Sep 25, 2017

@micheleg The branch is indeed working.

azzar1 · Sep 25, 2017

http://paste.ubuntu.com/25615125/ This a simple python script that can be used to test the code. This code does not uset libunity.

franglais125 · Sep 25, 2017

franglais125 reviewed Sep 25, 2017

View changes

@azzar1 I used your new script (thanks!), and got this running on Gnome 3.22.

This line is throwing an error for me, since Debian is still on mozJS 24.

Perhaps we can change includes (which is not supported until mozJS 52) with:

if (!remote || this._remoteEntries.indexOf(remote) !== -1)

franglais125 · Sep 25, 2017

franglais125 reviewed Sep 25, 2017

View changes

Same here. includes -> indexOf

Thanks.

micheleg · Sep 25, 2017

I also manage to get the badges to work with your new script. I've merged the branch into master. I've only skipped the commit changing the default colour, which you might want to keep in the ubuntu-branch for the time being.

micheleg · Sep 25, 2017

I've seen you had already merged in the ubuntu branch and made a new release/announcement. Closing this pull request. Thanks for the contribution @azzar1 @didrocks @franglais125!

Reference to the commit in master: [5ef239d..a6fba76]

didrocks · Sep 26, 2017

Thanks a lot as usual @micheleg, @franglais125 to have make that easy for ubuntu! I think @azzar1 will help you once we release 17.10 to get the final options and touches done! ;)

gayanper · Oct 12, 2017

@micheleg Does the ubuntu feature (progress, badges) works on other distributions as well ? like antergos , fedora ?

azzar1 · Oct 12, 2017

If the application uses the unity launcher API yes. E.g. I didn't checked but electron apps should work.

…

Support older version of gjs.

52fa8b3

This was referenced Sep 6, 2017

Open

Provide Unity Launcher API #591

Open

Progress on icons (merge from dash-to-dock) jderose9/dash-to-panel#98

Open

Indicator for unread messages jderose9/dash-to-panel#126

Merge remote-tracking branch 'origin/master' into add-counters

4f628f5

micheleg referenced this pull request Sep 17, 2017
Closed
Possibility to show count of unread messages in dock #595

azzar1 added some commits Sep 20, 2017

Support progress bar.

2bed1e1

Add drawRoundedLine to utils.js

b273d8c

Minor changes after review

5a370bb

Change the default color

8932f87

micheleg closed this Sep 25, 2017

cra0zy referenced this pull request in picoe/Eto Sep 25, 2017
Open
Implement taskbar progressbar #763

Feichtmeier referenced this pull request in Foundry376/Mailspring Dec 10, 2017
Open
Ubuntu 17.10 GNOME DE: no ICON badge for unread mails #420

+        +        if (count <= 9999) {
+        +            return count.toString();
+        +        } else if (count < 10**5) {
+        +            let thousands = count / 10**3;

@@ -1636,6 +1668,7 @@ var DockManager = new Lang.Class({
              Name: 'DashToDock.DockManager',
              _init: function() {
+        +        this._remoteModel = new LauncherAPI.LauncherEntryRemoteModel();

micheleg/dash-to-dock

Join GitHub today

Initial support for 'com.canonical.Unity.LauncherEntry' APIs #590

Conversation

azzar1 commented Sep 5, 2017

azzar1 added some commits Sep 1, 2017

micheleg reviewed Sep 6, 2017 View changes

micheleg reviewed Sep 6, 2017 View changes

micheleg commented Sep 6, 2017

azzar1 commented Sep 6, 2017

This was referenced Sep 6, 2017

micheleg referenced this pull request Sep 17, 2017

azzar1 commented Sep 20, 2017

azzar1 added some commits Sep 20, 2017

azzar1 commented Sep 20, 2017

didrocks commented Sep 20, 2017

franglais125 reviewed Sep 20, 2017 View changes

franglais125 reviewed Sep 20, 2017 View changes

franglais125 commented Sep 20, 2017

franglais125 reviewed Sep 20, 2017 View changes

azzar1 commented Sep 20, 2017

micheleg commented Sep 21, 2017

azzar1 commented Sep 21, 2017

micheleg commented Sep 21, 2017

franglais125 commented Sep 21, 2017

azzar1 commented Sep 22, 2017

micheleg commented Sep 24, 2017

franglais125 commented Sep 24, 2017 • edited Edited 1 time franglais125 Sep 24, 2017

azzar1 commented Sep 25, 2017

azzar1 commented Sep 25, 2017

franglais125 reviewed Sep 25, 2017 View changes

franglais125 Sep 25, 2017 • edited Edited 1 time franglais125 Sep 25, 2017

franglais125 reviewed Sep 25, 2017 View changes

micheleg commented Sep 25, 2017

micheleg commented Sep 25, 2017

micheleg closed this Sep 25, 2017

cra0zy referenced this pull request in picoe/Eto Sep 25, 2017

didrocks commented Sep 26, 2017

gayanper commented Oct 12, 2017

azzar1 commented Oct 12, 2017

Feichtmeier referenced this pull request in Foundry376/Mailspring Dec 10, 2017

micheleg reviewed Sep 6, 2017

View changes

micheleg reviewed Sep 6, 2017

View changes

franglais125 reviewed Sep 20, 2017

View changes

franglais125 reviewed Sep 20, 2017

View changes

franglais125 reviewed Sep 20, 2017

View changes

franglais125 commented Sep 24, 2017 •

Edited 1 time

franglais125
Sep 24, 2017

franglais125 reviewed Sep 25, 2017

View changes

franglais125 Sep 25, 2017 •

Edited 1 time

franglais125
Sep 25, 2017

franglais125 reviewed Sep 25, 2017

View changes