dash, docking: remove Shell.GenericContainer #825
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been removed upstream, and extending components instead of compositing them with the delegate pattern is suggested.
|
Thanks for the PR. I don't think this this will break anything in prior versions, as this is what I used to do long time ago. The reason I moved away (41a315c) was to avoid errors when live updating the extension (I was flooded with bug reports at each new version release on the extension website). |
|
On my system (Debian stable, Gnome 3.22 this makes the shell crash. The problem seems to be related to the oject name, as ''.' seems not to be allowed. See https://github.com/GNOME/glib/blob/master/gobject/gtype.c#L747 I assume it's working somehow in newer Gnome versions or you would have encountered the issues. I renamed the classes (DashToDock.DashSlideContainer and DashToDock.MyDashActor) and merged as [421efee] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been removed upstream, and extending components instead of compositing them with the delegate pattern is suggested.
We still might use composition by using fake St.Widgets that replicate the same locally, but I guess it's better to follow what upstream does.
Not sure if this means breaking old compatibility though.