Fix the 'role does not exist' error caused by uppercase characters in… #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for delay! I approved test workflow, looks like some function signature checks are missing updates: https://github.com/michelp/pgsodium/pull/90/checks |
|
Sorry, I just updated the signatures of these functions. Could you please check them again? |
michelp
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the current
session_usercontains uppercase characters, calling theupdate_masksandcreate_mask_viewfunctions will throw a 'role does not exist' error.We need to use
quote_ident()to preserve the case, and ensure theview_ownerstored username is consistent withsession_user, containing the correct case.