Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Would you mind using home_url instead of site_url #39

Closed
k-kikuchi-waverworks opened this issue Sep 10, 2020 · 1 comment
Closed

Would you mind using home_url instead of site_url #39

k-kikuchi-waverworks opened this issue Sep 10, 2020 · 1 comment
Labels
enhancement

Comments

@k-kikuchi-waverworks
Copy link

Hello
Thank you for providing good plugin and quick support for bug fix.

I looked into your code to check following issue
#33
#38

and. I realized that you use site_url instead of home_url.

Multilingual plugins like Bogo, WPML, Polylang use home_url to apply their filter hook to activate multilingual feature.

so, would mind using home_url instead of site_url ?
Plugin authors will sell products globally, this might cause an error in some case.

King Regards

KAZUKI
@michelve
Copy link
Owner

I have upgraded this functionality - thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michelve @k-kikuchi-waverworks