Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing #198 and the issue found by @d8ahazard
This PR brings the following fixes:
The rational to use a shared HttpClient is from:
This is actually the way the
HueClient
class is built, with either a shared HttpClient, or a given one by the user in the constructor.I choose not to change the
IBridgeLocator
signature for now and use a local common HttpClient. But if you want me to add a new constructor signature to match theHueClient
class, feel free to ask.