Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Algorithm in disk query? #12

Open
cdeil opened this issue Jun 24, 2018 · 1 comment
Open

Algorithm in disk query? #12

cdeil opened this issue Jun 24, 2018 · 1 comment

Comments

@cdeil
Copy link
Contributor

cdeil commented Jun 24, 2018

@michitaro - Is the algorithm you use for disk query described somewhere?
(a webpage or paper?)

If no, could you please add a few comments to the docstring to make it easier to understand what it does?

export function query_disc_inclusive_nest(nside: number, v: V3, radius: number, cb: (ipix: number) => void) {

@cdeil
Copy link
Contributor Author

cdeil commented Jun 26, 2018

I've found a description of the HEALPix query algorithm used in the C++ implementation:
See Section 7 in http://adsabs.harvard.edu/abs/2015A&A...580A.132R

I still have to review and understand the call-back based implementation here by @michitaro and the algorithm by @dstndstn in here.

@michitaro @dstndstn - Can you comment on how your implementation compares to the one proposed there, and which one you think we should use (here in the Typescript and there in the C implementation)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant