Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency Conflict with @sveltejs/kit and @sveltejs/adapter-static in sveltekit-adapter-chrome-extension #33

Closed
socketopp opened this issue Jan 22, 2024 · 3 comments · Fixed by #35 or #36

Comments

@socketopp
Copy link

While installing.

$ npm i -D sveltekit-adapter-chrome-extension

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: sirbookmarksalot@0.0.1
npm ERR! Found: @sveltejs/kit@2.4.2
npm ERR! node_modules/@sveltejs/kit
npm ERR!   dev @sveltejs/kit@"^2.0.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer @sveltejs/kit@"^1.5.0" from @sveltejs/adapter-static@2.0.3
npm ERR! node_modules/@sveltejs/adapter-static
npm ERR!   peer @sveltejs/adapter-static@"^2.0.1" from sveltekit-adapter-chrome-extension@2.0.0
npm ERR!   node_modules/sveltekit-adapter-chrome-extension
npm ERR!     dev sveltekit-adapter-chrome-extension@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

We need to update the versions of @sveltejs/kit, @sveltejs/adapter-static, and sveltekit-adapter-chrome-extension in your package.json file to be compatible with each other.

@Jack-Barry
Copy link
Contributor

Building the package locally with this fixed it for me:

  "peerDependencies": {
    "@sveltejs/adapter-static": "^3.0.1"
  }

I'm fine with opening a PR for this, but given the lack of maintenance commits lately I wonder if just forking and/or spinning up a new adapter module is a better path forward?

@michmich112
Copy link
Owner

@Jack-Barry feel free to open any PRs.
I'll be updating the packages and re-deploying updates.

@michmich112
Copy link
Owner

michmich112 commented Mar 25, 2024

Thank you @Jack-Barry
Please update to v2.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants